Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 17:21, Jamal Hadi Salim wrote: > On 2019-10-23 9:04 a.m., Vlad Buslov wrote: >> >> On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: >>> Hi Vlad, >>> > >>> I understand your use case being different since it is for h/w >>> offload. If you have time can you test with bat

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
On 2019-10-23 9:04 a.m., Vlad Buslov wrote: On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: Hi Vlad, I understand your use case being different since it is for h/w offload. If you have time can you test with batching many actions and seeing the before/after improvement? Will do. T

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 16:02, Jamal Hadi Salim wrote: > I shouldve read the thread backward. My earlier email was asking > similar question to Roman. > > On 2019-10-23 2:38 a.m., Vlad Buslov wrote: >> >> On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: > >> Hi Roman, >> >> I considered it, but d

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
I shouldve read the thread backward. My earlier email was asking similar question to Roman. On 2019-10-23 2:38 a.m., Vlad Buslov wrote: On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: Hi Roman, I considered it, but didn't find good way to implement my change with TCA_ROOT_FLAGS. I neede

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Vlad Buslov
On Wed 23 Oct 2019 at 15:49, Jamal Hadi Salim wrote: > Hi Vlad, > > On 2019-10-22 10:17 a.m., Vlad Buslov wrote: >> Currently, significant fraction of CPU time during TC filter allocation >> is spent in percpu allocator. Moreover, percpu allocator is protected >> with single global mutex which n

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-23 Thread Jamal Hadi Salim
Hi Vlad, On 2019-10-22 10:17 a.m., Vlad Buslov wrote: Currently, significant fraction of CPU time during TC filter allocation is spent in percpu allocator. Moreover, percpu allocator is protected with single global mutex which negates any potential to improve its performance by means of recent

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 20:09, Marcelo Ricardo Leitner wrote: > On Tue, Oct 22, 2019 at 03:52:31PM +, Vlad Buslov wrote: >> >> On Tue 22 Oct 2019 at 18:15, Marcelo Ricardo Leitner >> wrote: >> > On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >> >> - Extend actions that are use

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 21:17, Roman Mashak wrote: > Vlad Buslov writes: > >> On Tue 22 Oct 2019 at 17:35, Marcelo Ricardo Leitner >> wrote: >>> On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: Currently, significant fraction of CPU time during TC filter allocation is spen

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Roman Mashak
Vlad Buslov writes: > On Tue 22 Oct 2019 at 17:35, Marcelo Ricardo Leitner > wrote: >> On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >>> Currently, significant fraction of CPU time during TC filter allocation >>> is spent in percpu allocator. Moreover, percpu allocator is protect

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Marcelo Ricardo Leitner
On Tue, Oct 22, 2019 at 03:52:31PM +, Vlad Buslov wrote: > > On Tue 22 Oct 2019 at 18:15, Marcelo Ricardo Leitner > wrote: > > On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: > >> - Extend actions that are used for hardware offloads with optional > >> netlink 32bit flags field

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 18:15, Marcelo Ricardo Leitner wrote: > On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >> - Extend actions that are used for hardware offloads with optional >> netlink 32bit flags field. Add TCA_ACT_FLAGS_FAST_INIT action flag and >> update affected actio

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Marcelo Ricardo Leitner
On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: > - Extend actions that are used for hardware offloads with optional > netlink 32bit flags field. Add TCA_ACT_FLAGS_FAST_INIT action flag and > update affected actions to not allocate percpu counters when the flag > is set. I just

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
On Tue 22 Oct 2019 at 17:35, Marcelo Ricardo Leitner wrote: > On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: >> Currently, significant fraction of CPU time during TC filter allocation >> is spent in percpu allocator. Moreover, percpu allocator is protected >> with single global mu

Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Marcelo Ricardo Leitner
On Tue, Oct 22, 2019 at 05:17:51PM +0300, Vlad Buslov wrote: > Currently, significant fraction of CPU time during TC filter allocation > is spent in percpu allocator. Moreover, percpu allocator is protected > with single global mutex which negates any potential to improve its > performance by means

[PATCH net-next 00/13] Control action percpu counters allocation by netlink flag

2019-10-22 Thread Vlad Buslov
Currently, significant fraction of CPU time during TC filter allocation is spent in percpu allocator. Moreover, percpu allocator is protected with single global mutex which negates any potential to improve its performance by means of recent developments in TC filter update API that removed rtnl loc