Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-25 Thread David Ahern
On 11/24/20 11:00 PM, Parav Pandit wrote: > Hi David, > >> From: David Ahern >> Sent: Wednesday, November 25, 2020 11:04 AM >> >> On 11/18/20 10:57 PM, Saeed Mahameed wrote: >>> >>> We are not slicing up any queues, from our HW and FW perspective SF == >>> VF literally, a full blown HW slice (Fun

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-24 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Wednesday, November 25, 2020 11:04 AM > > On 11/18/20 10:57 PM, Saeed Mahameed wrote: > > > > We are not slicing up any queues, from our HW and FW perspective SF == > > VF literally, a full blown HW slice (Function), with isolated control > > and data plane

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-24 Thread David Ahern
On 11/18/20 10:57 PM, Saeed Mahameed wrote: > > We are not slicing up any queues, from our HW and FW perspective SF == > VF literally, a full blown HW slice (Function), with isolated control > and data plane of its own, this is very different from VMDq and more > generic and secure. an SF device i

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-23 Thread Jason Wang
On 2020/11/24 下午3:01, Jason Wang wrote: On 2020/11/21 上午3:04, Samudrala, Sridhar wrote: On 11/20/2020 9:58 AM, Alexander Duyck wrote: On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote: On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: On 11/18/20 7:14 PM, Jakub Kicinski wrote:

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-23 Thread Jason Wang
On 2020/11/21 上午3:04, Samudrala, Sridhar wrote: On 11/20/2020 9:58 AM, Alexander Duyck wrote: On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote: On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: On 11/18/20 7:14 PM, Jakub Kicinski wrote: On Tue, 17 Nov 2020 14:49:54 -0400 Jason G

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-23 Thread Saeed Mahameed
On Fri, 2020-11-20 at 11:04 -0800, Samudrala, Sridhar wrote: > > On 11/20/2020 9:58 AM, Alexander Duyck wrote: > > On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski > > wrote: > > > On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: > > > > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > > > > On

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-20 Thread Samudrala, Sridhar
On 11/20/2020 9:58 AM, Alexander Duyck wrote: On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote: On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: On 11/18/20 7:14 PM, Jakub Kicinski wrote: On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: On Tue, Nov 17, 2020 at 09:11:20A

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-20 Thread Alexander Duyck
On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: > > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > >> On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > >

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-20 Thread Jason Gunthorpe
On Thu, Nov 19, 2020 at 07:35:26PM -0800, Jakub Kicinski wrote: > On Thu, 19 Nov 2020 10:00:17 -0400 Jason Gunthorpe wrote: > > Finally, in the mlx5 model VDPA is just an "application". It asks the > > device to create a 'RDMA' raw ethernet packet QP that is uses rings > > formed in the virtio-net

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, November 20, 2020 9:05 AM > > On Thu, 19 Nov 2020 10:00:17 -0400 Jason Gunthorpe wrote: > > Finally, in the mlx5 model VDPA is just an "application". It asks the > > device to create a 'RDMA' raw ethernet packet QP that is uses rings > > formed in the virtio

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 10:00:17 -0400 Jason Gunthorpe wrote: > Finally, in the mlx5 model VDPA is just an "application". It asks the > device to create a 'RDMA' raw ethernet packet QP that is uses rings > formed in the virtio-net specification. We can create it in the kernel > using mlx5_vdpa, and we

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, November 20, 2020 7:05 AM > > On Wed, 18 Nov 2020 22:12:22 -0800 Saeed Mahameed wrote: > > > Right, devices of other subsystems are fine, I don't care. > > > > But a netdev will be loaded on SF automatically just through the > > current driver design and m

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 22:12:22 -0800 Saeed Mahameed wrote: > > Right, devices of other subsystems are fine, I don't care. > > But a netdev will be loaded on SF automatically just through the > current driver design and modularity, since SF == VF and our netdev is > abstract and doesn't know if it ru

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:57:57 -0800 Saeed Mahameed wrote: > On Wed, 2020-11-18 at 21:35 -0700, David Ahern wrote: > > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote:

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > >> On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > >> > Just to refresh all our memory, we discussed and sett

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jason Gunthorpe
On Wed, Nov 18, 2020 at 10:22:51PM -0800, Saeed Mahameed wrote: > > I think the biggest missing piece in my understanding is what's the > > technical difference between an SF and a VDPA device. > > Same difference as between a VF and netdev. > SF == VF, so a full HW function. > VDPA/RDMA/netdev/SC

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Saeed Mahameed > Sent: Thursday, November 19, 2020 11:42 AM > > From how this discussion is going, i think you are right, we need to clarify > what we are doing in a more high level simplified and generic documentation > to give some initial context, Parav, let's add the missing documen

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 18:23 -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 18:50:57 + Parav Pandit wrote: > > At this point vdpa tool of [1] can create one or more vdpa net > > devices on this subfunction device in below sequence. > > > > $ vdpa parentdev list > > auxiliary/mlx5_core.sf.4

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 18:14 -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > It is consistent with the multi-subsystem device sharing model > > we've > > had for ages now. > > > > T

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 21:35 -0700, David Ahern wrote: > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > > > > > Just to refresh all our memory, we discussed and se

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread David Ahern
On 11/18/20 7:14 PM, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: >> On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: >> Just to refresh all our memory, we discussed and settled on the flow in [2]; RFC [1] followed this discussion.

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 18:50:57 + Parav Pandit wrote: > At this point vdpa tool of [1] can create one or more vdpa net devices on > this subfunction device in below sequence. > > $ vdpa parentdev list > auxiliary/mlx5_core.sf.4 > supported_classes > net > > $ vdpa dev add parentdev auxili

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > Just to refresh all our memory, we discussed and settled on the flow > > > in [2]; RFC [1] followed this discussion. > > > > > > vdpa tool of [3] can add one or more

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-17 Thread Parav Pandit
Hi Jakub, > From: Jakub Kicinski > Sent: Tuesday, November 17, 2020 10:41 PM > > On Tue, 17 Nov 2020 04:08:57 + Parav Pandit wrote: > > > On Mon, 16 Nov 2020 16:06:02 -0800 Saeed Mahameed wrote: > > > > > > Subfunction support is discussed in detail in RFC [1] and [2]. > > > > > > RFC [1] an

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-17 Thread Jason Gunthorpe
On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > Just to refresh all our memory, we discussed and settled on the flow > > in [2]; RFC [1] followed this discussion. > > > > vdpa tool of [3] can add one or more vdpa device(s) on top of already > > spawned PF, VF, SF device. > >

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 04:08:57 + Parav Pandit wrote: > > On Mon, 16 Nov 2020 16:06:02 -0800 Saeed Mahameed wrote: > > > > > Subfunction support is discussed in detail in RFC [1] and [2]. > > > > > RFC [1] and extension [2] describes requirements, design, and > > > > > proposed plumbing using de

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-16 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Tuesday, November 17, 2020 7:28 AM > > On Mon, 16 Nov 2020 16:06:02 -0800 Saeed Mahameed wrote: > > > > Subfunction support is discussed in detail in RFC [1] and [2]. > > > > RFC [1] and extension [2] describes requirements, design, and > > > > proposed plumbing u

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 16:06:02 -0800 Saeed Mahameed wrote: > On Mon, 2020-11-16 at 14:52 -0800, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 21:24:10 +0200 Parav Pandit wrote: > > > This series introduces support for mlx5 subfunction (SF). > > > A subfunction is a portion of a PCI device that supp

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-16 Thread Saeed Mahameed
On Mon, 2020-11-16 at 14:52 -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 21:24:10 +0200 Parav Pandit wrote: > > This series introduces support for mlx5 subfunction (SF). > > A subfunction is a portion of a PCI device that supports multiple > > classes of devices such as netdev, RDMA and more.

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-16 Thread Jakub Kicinski
On Thu, 12 Nov 2020 21:24:10 +0200 Parav Pandit wrote: > This series introduces support for mlx5 subfunction (SF). > A subfunction is a portion of a PCI device that supports multiple > classes of devices such as netdev, RDMA and more. > > This patchset is based on Leon's series [3]. > It is a thir

[PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-12 Thread Parav Pandit
Hi Dave, Jakub, Greg, This series introduces support for mlx5 subfunction (SF). A subfunction is a portion of a PCI device that supports multiple classes of devices such as netdev, RDMA and more. This patchset is based on Leon's series [3]. It is a third user of proposed auxiliary bus [4]. Subfu