Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-14 Thread Ido Schimmel
On Sun, Jul 14, 2019 at 07:29:04AM -0400, Neil Horman wrote: > On Fri, Jul 12, 2019 at 04:52:30PM +0300, Ido Schimmel wrote: > > On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > > > A few things here: > > > IIRC we don't announce individual hardware drops, drivers record them in > > >

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-14 Thread Neil Horman
On Fri, Jul 12, 2019 at 04:52:30PM +0300, Ido Schimmel wrote: > On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > > A few things here: > > IIRC we don't announce individual hardware drops, drivers record them in > > internal structures, and they are retrieved on demand via ethtool call

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-13 Thread David Miller
From: Ido Schimmel Date: Thu, 11 Jul 2019 15:39:09 +0300 > Before I start working on v2, I would like to get your feedback on the > high level plan. Also adding Neil who is the maintainer of drop_monitor > (and counterpart DropWatch tool [1]). > > IIUC, the problem you point out is that users ne

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-13 Thread Toke Høiland-Jørgensen
>Neil Horman writes: > On Fri, Jul 12, 2019 at 02:33:29PM +0200, Toke Høiland-Jørgensen wrote: >> Neil Horman writes: >> >> > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: >> >> Neil Horman writes: >> >> >> >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Fri, Jul 12, 2019 at 02:33:29PM +0200, Toke Høiland-Jørgensen wrote: > Neil Horman writes: > > > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: > >> Neil Horman writes: > >> > >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: > >> >> On Sun, Jul 07,

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Ido Schimmel
On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > A few things here: > IIRC we don't announce individual hardware drops, drivers record them in > internal structures, and they are retrieved on demand via ethtool calls, so > you > will either need to include some polling (probably not

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Toke Høiland-Jørgensen
Neil Horman writes: > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: >> Neil Horman writes: >> >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: >> >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: >> >> > From: Ido Schimmel >> >> > Date

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: > Neil Horman writes: > > > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: > >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > >> > From: Ido Schimmel > >> > Date: Sun, 7 Jul 2019 10:58:17 +0

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Thu, Jul 11, 2019 at 08:40:34PM -0700, Florian Fainelli wrote: > > > On 7/11/2019 4:53 PM, Neil Horman wrote: > >> I would like to emphasize that the configuration of whether these > >> dropped packets are even sent to the CPU from the device still needs to > >> reside in devlink given this is

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Toke Høiland-Jørgensen
Neil Horman writes: > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: >> > From: Ido Schimmel >> > Date: Sun, 7 Jul 2019 10:58:17 +0300 >> > >> > > Users have several ways to debug the kernel and understand why a pa

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-11 Thread Florian Fainelli
On 7/11/2019 4:53 PM, Neil Horman wrote: >> I would like to emphasize that the configuration of whether these >> dropped packets are even sent to the CPU from the device still needs to >> reside in devlink given this is the go-to tool for device-specific >> configuration. In addition, these drop

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-11 Thread Neil Horman
On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > > From: Ido Schimmel > > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > > > Users have several ways to debug the kernel and understand why a packet > > > was dropped. For e

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-11 Thread David Miller
From: Ido Schimmel Date: Thu, 11 Jul 2019 15:39:09 +0300 > Before I start working on v2, I would like to get your feedback on the > high level plan. Also adding Neil who is the maintainer of drop_monitor > (and counterpart DropWatch tool [1]). I'll try to get back to this, but right now the merg

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-11 Thread Ido Schimmel
On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > From: Ido Schimmel > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > Users have several ways to debug the kernel and understand why a packet > > was dropped. For example, using "drop monitor" and "perf". Both > > utilities trace kfree_sk

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-10 Thread Toke Høiland-Jørgensen
Ido Schimmel writes: > On Tue, Jul 09, 2019 at 03:34:30PM -0700, Jakub Kicinski wrote: >> On Tue, 9 Jul 2019 15:38:44 +0300, Ido Schimmel wrote: >> > On Mon, Jul 08, 2019 at 03:51:58PM -0700, Jakub Kicinski wrote: >> > > On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: >> > > > On Sun, Ju

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-10 Thread Ido Schimmel
On Tue, Jul 09, 2019 at 03:34:30PM -0700, Jakub Kicinski wrote: > On Tue, 9 Jul 2019 15:38:44 +0300, Ido Schimmel wrote: > > On Mon, Jul 08, 2019 at 03:51:58PM -0700, Jakub Kicinski wrote: > > > On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: > > > > On Sun, Jul 07, 2019 at 12:45:41PM -070

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-09 Thread Jakub Kicinski
On Tue, 9 Jul 2019 15:38:44 +0300, Ido Schimmel wrote: > On Mon, Jul 08, 2019 at 03:51:58PM -0700, Jakub Kicinski wrote: > > On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: > > > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > > > > From: Ido Schimmel > > > > Date: Sun,

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-09 Thread Ido Schimmel
On Mon, Jul 08, 2019 at 03:51:58PM -0700, Jakub Kicinski wrote: > On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: > > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > > > From: Ido Schimmel > > > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > > > > > Users have several ways t

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-08 Thread Jakub Kicinski
On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote: > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > > From: Ido Schimmel > > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > > > Users have several ways to debug the kernel and understand why a packet > > > was dropped. For exampl

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-08 Thread Ido Schimmel
On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > From: Ido Schimmel > Date: Sun, 7 Jul 2019 10:58:17 +0300 > > > Users have several ways to debug the kernel and understand why a packet > > was dropped. For example, using "drop monitor" and "perf". Both > > utilities trace kfree_sk

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread David Miller
From: Ido Schimmel Date: Sun, 7 Jul 2019 10:58:17 +0300 > Users have several ways to debug the kernel and understand why a packet > was dropped. For example, using "drop monitor" and "perf". Both > utilities trace kfree_skb(), which is the function called when a packet > is freed as part of a fa

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread Ido Schimmel
More info that I did not want to put in the cover letter: Wrote a Wireshark dissector [1] for devlink packets. It dissects various devlink packets and is especially useful for trap report packets. Both the metadata about the trapped packet (e.g., trap reason) and also the trapped Ethernet packet i

[PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Users have several ways to debug the kernel and understand why a packet was dropped. For example, using "drop monitor" and "perf". Both utilities trace kfree_skb(), which is the function called when a packet is freed as part of a failure. The information provided by these tools