Re: [PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread Alex Elder
On 3/4/21 9:44 PM, subas...@codeaurora.org wrote: Can you share what all tests have been done with these patches I'm testing with all of them applied and "it works." On the first three I think they're simple enough that you can see by inspection they should be OK. For the rest I tested more

Re: [PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread subashab
On 2021-03-04 15:34, Alex Elder wrote: This series converts data structures defined in so they use integral field values with bitfield masks rather than rely on C bit-fields. I first proposed doing something like this long ago when my confusion about this code (and the memory layout it was supp

Re: [PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread Alex Elder
On 3/4/21 4:34 PM, Alex Elder wrote: This series converts data structures defined in so they use integral field values with bitfield masks rather than rely on C bit-fields. Whoops! I forgot to check if net-next was open. I'm very sorry about that... http://vger.kernel.org/~davem/net-next.

[PATCH net-next 0/6] net: qualcomm: rmnet: stop using C bit-fields

2021-03-04 Thread Alex Elder
This series converts data structures defined in so they use integral field values with bitfield masks rather than rely on C bit-fields. I first proposed doing something like this long ago when my confusion about this code (and the memory layout it was supposed to represent) led me to believe it w