Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-05 Thread David Miller
From: Eric Dumazet Date: Fri, 5 Oct 2018 06:08:57 -0700 > For some reason I have not received the patch series in my inbox, I > only got your "series applied" message. I see what happened. I did something stupid on vger.kernel.org yesterday which ran a partition out of disk space, and some post

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-05 Thread David Ahern
On 10/5/18 7:08 AM, Eric Dumazet wrote: > Commit 767a2217533fed6 ("net: common metrics init helper for FIB entries") > is not correct because we need to better deal with error paths. > > I will submit this more formally when I can reach my workstation in a few > minutes : > > diff --git a/net/ip

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-05 Thread Eric Dumazet
On 10/05/2018 05:17 AM, Eric Dumazet wrote: > > > On 10/04/2018 09:55 PM, David Miller wrote: >> From: David Ahern >> Date: Thu, 4 Oct 2018 20:07:50 -0700 >> >>> From: David Ahern >>> >>> As part of the IPv6 fib info refactoring, the intent was to make metrics >>> handling for ipv6 identica

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-05 Thread Eric Dumazet
On 10/04/2018 09:55 PM, David Miller wrote: > From: David Ahern > Date: Thu, 4 Oct 2018 20:07:50 -0700 > >> From: David Ahern >> >> As part of the IPv6 fib info refactoring, the intent was to make metrics >> handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy >> led to conf

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-04 Thread David Miller
From: David Ahern Date: Thu, 4 Oct 2018 20:07:50 -0700 > From: David Ahern > > As part of the IPv6 fib info refactoring, the intent was to make metrics > handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy > led to confusion and a couple of incomplete attempts at finding and