Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-11 Thread Andrew Lunn
> Vivien, Andrew, are you aware of an use case where we have the HW > programmed with a superset of VLANs wrt. the SW bridge? I cannot think of any case with a superset. Subset yes, but not superset. Andrew

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Florian Fainelli
On 01/10/2017 08:08 AM, Ido Schimmel wrote: > On Tue, Jan 10, 2017 at 03:18:07PM +0100, Jiri Pirko wrote: >> Tue, Jan 10, 2017 at 02:25:06PM CET, ido...@idosch.org wrote: >>> On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org wrot

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread David Miller
From: Florian Fainelli Date: Mon, 9 Jan 2017 12:56:48 -0800 > On 01/09/2017 12:48 PM, Ido Schimmel wrote: >> Hi Florian, >> >> On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: >>> Hi all, >>> >>> This patch series is to resolve a sleeping function called in atomic context >>> de

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 05:08:52PM CET, ido...@idosch.org wrote: >On Tue, Jan 10, 2017 at 03:18:07PM +0100, Jiri Pirko wrote: >> Tue, Jan 10, 2017 at 02:25:06PM CET, ido...@idosch.org wrote: >> >On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: >> >> Mon, Jan 09, 2017 at 10:14:36PM CET, ido.

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Ido Schimmel
On Tue, Jan 10, 2017 at 03:18:07PM +0100, Jiri Pirko wrote: > Tue, Jan 10, 2017 at 02:25:06PM CET, ido...@idosch.org wrote: > >On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: > >> Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org wrote: > >> >On Mon, Jan 09, 2017 at 12:56:48PM -080

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Jiri Pirko
Tue, Jan 10, 2017 at 02:25:06PM CET, ido...@idosch.org wrote: >On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: >> Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org wrote: >> >On Mon, Jan 09, 2017 at 12:56:48PM -0800, Florian Fainelli wrote: >> >> On 01/09/2017 12:48 PM, Ido Schimme

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Ido Schimmel
On Tue, Jan 10, 2017 at 01:08:46PM +0100, Jiri Pirko wrote: > Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org wrote: > >On Mon, Jan 09, 2017 at 12:56:48PM -0800, Florian Fainelli wrote: > >> On 01/09/2017 12:48 PM, Ido Schimmel wrote: > >> > Hi Florian, > >> > > >> > On Mon, Jan 09, 2017 at

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-10 Thread Jiri Pirko
Mon, Jan 09, 2017 at 10:14:36PM CET, ido...@idosch.org wrote: >On Mon, Jan 09, 2017 at 12:56:48PM -0800, Florian Fainelli wrote: >> On 01/09/2017 12:48 PM, Ido Schimmel wrote: >> > Hi Florian, >> > >> > On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: >> >> Hi all, >> >> >> >> Thi

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Ido Schimmel
On Mon, Jan 09, 2017 at 10:23:20PM +0100, Andrew Lunn wrote: > > Truth be told, I don't quite understand why switchdev infra even tries > > to dump the VLANs from the device. Like, in which situations is this > > going to be different from what the software bridge reports? > > What happens when th

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Andrew Lunn
> Truth be told, I don't quite understand why switchdev infra even tries > to dump the VLANs from the device. Like, in which situations is this > going to be different from what the software bridge reports? What happens when the hardware is out of resources and says sorry, cannot do that. There ha

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Vivien Didelot
Hi Florian, Ido, Florian Fainelli writes: >> Can't you just cache the PVID as well? I think this will solve your >> problem. Didn't look too much into the b53 code, so maybe I'm missing >> something. Seems that mv88e6xxx has a similar problem. > > I suppose we could indeed cache the PVID for b53

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Ido Schimmel
On Mon, Jan 09, 2017 at 12:56:48PM -0800, Florian Fainelli wrote: > On 01/09/2017 12:48 PM, Ido Schimmel wrote: > > Hi Florian, > > > > On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: > >> Hi all, > >> > >> This patch series is to resolve a sleeping function called in atomic > >

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Andrew Lunn
On Mon, Jan 09, 2017 at 10:48:49PM +0200, Ido Schimmel wrote: > Hi Florian, > > On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: > > Hi all, > > > > This patch series is to resolve a sleeping function called in atomic context > > debug splat that we observe with DSA. > > > > Let

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Florian Fainelli
On 01/09/2017 12:48 PM, Ido Schimmel wrote: > Hi Florian, > > On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: >> Hi all, >> >> This patch series is to resolve a sleeping function called in atomic context >> debug splat that we observe with DSA. >> >> Let me know what you think, I

Re: [PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Ido Schimmel
Hi Florian, On Mon, Jan 09, 2017 at 11:44:59AM -0800, Florian Fainelli wrote: > Hi all, > > This patch series is to resolve a sleeping function called in atomic context > debug splat that we observe with DSA. > > Let me know what you think, I was also wondering if we should just always > make sw

[PATCH net-next 0/4] net: switchdev: Avoid sleep in atomic with DSA

2017-01-09 Thread Florian Fainelli
Hi all, This patch series is to resolve a sleeping function called in atomic context debug splat that we observe with DSA. Let me know what you think, I was also wondering if we should just always make switchdev_port_vlan_fill() set SWITCHDEV_F_DEFER, but was afraid this could cause invalid conte