Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-29 Thread David Ahern
On 3/27/17 9:08 PM, Eric W. Biederman wrote: > I believe we should just kill MAX_NEW_LABELS. > > I think the only significant change from your patch is the removal of an > array from mpls_route_config. > > With the removal of MAX_NEW_LABELS I would replace it by a sanity check > in mpls_rt_alloc

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-28 Thread David Ahern
On 3/27/17 9:08 PM, Eric W. Biederman wrote: > > Overall I like what is being accomplished by this patchset. > I especially like the fact that the forwarding path is left > essentially unchanged, and that the struct mpls_route shirnks a little > for the common case. > > I believe we should just k

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-28 Thread Robert Shearman
On 25/03/17 17:03, David Ahern wrote: Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array is moved to the end of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the maximum number of labels across all nex

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-28 Thread Robert Shearman
On 28/03/17 04:08, Eric W. Biederman wrote: David Ahern writes: On 3/27/17 4:39 AM, Robert Shearman wrote: On 25/03/17 19:15, Eric W. Biederman wrote: David Ahern writes: Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array i

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-27 Thread Eric W. Biederman
David Ahern writes: > On 3/27/17 4:39 AM, Robert Shearman wrote: >> On 25/03/17 19:15, Eric W. Biederman wrote: >>> David Ahern writes: >>> Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array is moved to the end of m

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-27 Thread David Miller
From: David Ahern Date: Sat, 25 Mar 2017 10:03:24 -0700 > Bump the maximum number of labels for MPLS routes from 2 to 12. This doesn't apply cleanly to net-next, please respin. Perhaps it conflicts with your recent cleanups.

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-27 Thread David Ahern
On 3/27/17 4:39 AM, Robert Shearman wrote: > On 25/03/17 19:15, Eric W. Biederman wrote: >> David Ahern writes: >> >>> Bump the maximum number of labels for MPLS routes from 2 to 12. To keep >>> memory consumption in check the labels array is moved to the end of >>> mpls_nh >>> and mpls_iptunnel_e

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-27 Thread Robert Shearman
On 25/03/17 19:15, Eric W. Biederman wrote: David Ahern writes: Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array is moved to the end of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the maximum nu

Re: [PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-25 Thread Eric W. Biederman
David Ahern writes: > Bump the maximum number of labels for MPLS routes from 2 to 12. To keep > memory consumption in check the labels array is moved to the end of mpls_nh > and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the > maximum number of labels across all nexthops in a

[PATCH net-next 0/4] net: mpls: Allow users to configure more labels per route

2017-03-25 Thread David Ahern
Bump the maximum number of labels for MPLS routes from 2 to 12. To keep memory consumption in check the labels array is moved to the end of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the maximum number of labels across all nexthops in a route for LSR and the number