Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-19 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Dec 2018 20:30:20 +0100 > On 19.12.2018 10:21, Andrew Lunn wrote: >> On Tue, Dec 18, 2018 at 09:46:56PM -0800, David Miller wrote: >>> From: Heiner Kallweit >>> Date: Tue, 18 Dec 2018 19:09:36 +0100 >>> Eventually defining 1Gbps as default isn’t something

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-19 Thread Heiner Kallweit
On 19.12.2018 10:21, Andrew Lunn wrote: > On Tue, Dec 18, 2018 at 09:46:56PM -0800, David Miller wrote: >> From: Heiner Kallweit >> Date: Tue, 18 Dec 2018 19:09:36 +0100 >> >>> Eventually defining 1Gbps as default isn’t something we would need to roll >>> back later once PHYs above 1Gbps are the s

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-19 Thread Andrew Lunn
On Tue, Dec 18, 2018 at 09:46:56PM -0800, David Miller wrote: > From: Heiner Kallweit > Date: Tue, 18 Dec 2018 19:09:36 +0100 > > > Eventually defining 1Gbps as default isn’t something we would need to roll > > back later once PHYs above 1Gbps are the standard. We can deal with this in > > phylib

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-18 Thread David Miller
From: Heiner Kallweit Date: Tue, 18 Dec 2018 19:09:36 +0100 > Eventually defining 1Gbps as default isn’t something we would need to roll > back later once PHYs above 1Gbps are the standard. We can deal with this in > phylib w/o affecting existing drivers. Therefore I think the proposed change > i

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-18 Thread Heiner Kallweit
On 18.12.2018 10:39, Andrew Lunn wrote: > On Tue, Dec 18, 2018 at 07:34:50AM +0100, Heiner Kallweit wrote: >> Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected, >> therefore it's not needed to define this manually in the driver. >> genphy_config_init() will remove 1Gbps from phydev->sup

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-18 Thread Andrew Lunn
On Tue, Dec 18, 2018 at 07:34:50AM +0100, Heiner Kallweit wrote: > Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected, > therefore it's not needed to define this manually in the driver. > genphy_config_init() will remove 1Gbps from phydev->supported if > not supported. Having said that P

[PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-17 Thread Heiner Kallweit
Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected, therefore it's not needed to define this manually in the driver. genphy_config_init() will remove 1Gbps from phydev->supported if not supported. Having said that PHY drivers for 100Mbps not calling genphy_config_init() still have to set