Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-18 Thread René van Dorst
Quoting Florian Fainelli : Hi Andrew and Florian, On 6/17/2019 6:53 PM, Andrew Lunn wrote: By adding some extra speed states in the code it seems to work. + if (state->speed == 1200) + mcr |= PMCR_FORCE_SPEED_1000; Hi René Is TRGMII always 1.2G? Or can y

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread Florian Fainelli
On 6/17/2019 6:53 PM, Andrew Lunn wrote: >> By adding some extra speed states in the code it seems to work. >> >> + if (state->speed == 1200) >> + mcr |= PMCR_FORCE_SPEED_1000; > > Hi René > > Is TRGMII always 1.2G? Or can you set it to 1000 or 1200? This >

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread Andrew Lunn
> By adding some extra speed states in the code it seems to work. > > + if (state->speed == 1200) > + mcr |= PMCR_FORCE_SPEED_1000; Hi René Is TRGMII always 1.2G? Or can you set it to 1000 or 1200? This PMCR_FORCE_SPEED_1000 feels wrong. > >We could consider

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread René van Dorst
Quoting Andrew Lunn : Hi Andrew, On Mon, Jun 17, 2019 at 09:33:12PM +, René van Dorst wrote: Quoting Andrew Lunn : >On Sun, Jun 16, 2019 at 08:20:08PM +0200, René van Dorst wrote: >>Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 >>switch both >>supports TRGMII mode.

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread Florian Fainelli
On 6/17/19 2:33 PM, René van Dorst wrote: > Quoting Andrew Lunn : > >> On Sun, Jun 16, 2019 at 08:20:08PM +0200, René van Dorst wrote: >>> Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 >>> switch both >>> supports TRGMII mode. MT7621 TRGMII speed is 1200MBit. >> >> Hi René

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread Andrew Lunn
On Mon, Jun 17, 2019 at 09:33:12PM +, René van Dorst wrote: > Quoting Andrew Lunn : > > >On Sun, Jun 16, 2019 at 08:20:08PM +0200, René van Dorst wrote: > >>Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 > >>switch both > >>supports TRGMII mode. MT7621 TRGMII speed is 12

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread René van Dorst
Quoting Andrew Lunn : On Sun, Jun 16, 2019 at 08:20:08PM +0200, René van Dorst wrote: Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 switch both supports TRGMII mode. MT7621 TRGMII speed is 1200MBit. Hi René Hi Andrew, Is TRGMII used only between the SoC and the

Re: [PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-17 Thread Andrew Lunn
On Sun, Jun 16, 2019 at 08:20:08PM +0200, René van Dorst wrote: > Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 switch > both > supports TRGMII mode. MT7621 TRGMII speed is 1200MBit. Hi René Is TRGMII used only between the SoC and the Switch? Or does external ports of the

[PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-16 Thread René van Dorst
Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 switch both supports TRGMII mode. MT7621 TRGMII speed is 1200MBit. René van Dorst (2): net: ethernet: mediatek: Add MT7621 TRGMII mode support net: dsa: mt7530: Add MT7621 TRGMII mode support drivers/net/dsa/mt7530.c