Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-25 Thread Benjamin LaHaise
On Tue, Apr 25, 2017 at 08:47:00AM -0400, Jamal Hadi Salim wrote: > On 17-04-25 07:55 AM, Simon Horman wrote: > [..] > > > > I agree something should be done wrt BOS. If the LABEL and TC are to > > be left as-is then I think a similar treatment of BOS - that is masking it > > - makes sense. > > >

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-25 Thread Jamal Hadi Salim
On 17-04-25 07:55 AM, Simon Horman wrote: [..] I agree something should be done wrt BOS. If the LABEL and TC are to be left as-is then I think a similar treatment of BOS - that is masking it - makes sense. I also agree with statements made earlier in the thread that it is unlikely that the unus

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-25 Thread Simon Horman
On Mon, Apr 24, 2017 at 07:07:43PM -0700, Jakub Kicinski wrote: > On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote: > > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote: > > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: > > > > > > > > Hrm. maybe I am wrong. > > > Lets say user sets all

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jakub Kicinski
On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote: > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote: > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: > > > > > Hrm. maybe I am wrong. > > Lets say user sets all of the 8 bits in BOS, > > what does setting > > key_val->mpls_bos = nla_get_u8

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 10:00 PM, Jamal Hadi Salim wrote: On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: Hrm. maybe I am wrong. Lets say user sets all of the 8 bits in BOS, what does setting key_val->mpls_bos = nla_get_u8 do? Same with the 20 bits for the label in the u32 or 3 bit bits in the u8 tc. Th

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: On 17-04-24 09:20 PM, Jakub Kicinski wrote: On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote: On 17-04-24 02:32 PM, David Miller wrote: You have 3 TLVs, one of which is u8 that only allows use of 3 bits. The other is a u32 which allows

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 09:20 PM, Jakub Kicinski wrote: On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote: On 17-04-24 02:32 PM, David Miller wrote: You have 3 TLVs, one of which is u8 that only allows use of 3 bits. The other is a u32 which allows only 20 bits to be set. I don't think we will

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 09:05 PM, Benjamin LaHaise wrote: On Mon, Apr 24, 2017 at 08:58:18PM -0400, Jamal Hadi Salim wrote: On 17-04-24 02:32 PM, David Miller wrote: You have 3 TLVs, one of which is u8 that only allows use of 3 bits. The other is a u32 which allows only 20 bits to be set. What are the

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jakub Kicinski
On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote: > On 17-04-24 02:32 PM, David Miller wrote: > > From: Benjamin LaHaise > > > > > Series applied, but in the future: > > > > 1) Put the "v2", "v3", whatever in the inital [PATCH xxx] bracketed > >part of the subject line, otherwise

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Benjamin LaHaise
On Mon, Apr 24, 2017 at 08:58:18PM -0400, Jamal Hadi Salim wrote: > On 17-04-24 02:32 PM, David Miller wrote: > > From: Benjamin LaHaise > > > > > Series applied, but in the future: > > > > 1) Put the "v2", "v3", whatever in the inital [PATCH xxx] bracketed > >part of the subject line, othe

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 02:32 PM, David Miller wrote: From: Benjamin LaHaise Series applied, but in the future: 1) Put the "v2", "v3", whatever in the inital [PATCH xxx] bracketed part of the subject line, otherwise it ends up in the GIT commit message header line and that's not desired. 2) Plea

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread David Miller
From: Benjamin LaHaise Date: Sat, 22 Apr 2017 16:52:45 -0400 > From: Benjamin LaHaise > > This patch series adds support for parsing MPLS flows in the flow dissector > and the flower classifier. Each of the MPLS TTL, BOS, TC and Label fields > can be used for matching. > > v2: incorporate sty

[PATCH net-next 0/2] flower: add MPLS matching support

2017-04-22 Thread Benjamin LaHaise
From: Benjamin LaHaise This patch series adds support for parsing MPLS flows in the flow dissector and the flower classifier. Each of the MPLS TTL, BOS, TC and Label fields can be used for matching. v2: incorporate style feedback, move #defines to linux/include/mpls.h Note: this omits Jiri's re