Re: [PATCH net-next] xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi

2018-12-20 Thread Steffen Klassert
On Wed, Dec 19, 2018 at 02:45:09PM +0800, YueHaibing wrote: > gcc warn this: > > net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn: > always true condition '(spi <= 4294967295) => (0-u32max <= u32max)' > > 'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX > because of wr

[PATCH net-next] xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi

2018-12-18 Thread YueHaibing
gcc warn this: net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn: always true condition '(spi <= 4294967295) => (0-u32max <= u32max)' 'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX because of wrap around. So the second forloop will never reach. Signed-off-by: YueHaib