Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-25 Thread Toshiaki Makita
On 2017/12/26 1:47, Florian Fainelli wrote: > On December 25, 2017 3:45:36 AM PST, Toshiaki Makita > wrote: >> On 2017/12/25 3:16, Stephen Hemminger wrote: >>> On Wed, 20 Dec 2017 13:40:37 +0900 >>> Toshiaki Makita wrote: >>> + +static const struct virtnet_gstats virtnet_gstrings_stats

Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-25 Thread Florian Fainelli
On December 25, 2017 3:45:36 AM PST, Toshiaki Makita wrote: >On 2017/12/25 3:16, Stephen Hemminger wrote: >> On Wed, 20 Dec 2017 13:40:37 +0900 >> Toshiaki Makita wrote: >> >>> + >>> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >>> + { "rx_packets", VIRTNET_NETDEV_

Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-25 Thread Toshiaki Makita
On 2017/12/25 3:16, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 13:40:37 +0900 > Toshiaki Makita wrote: > >> + >> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >> +{ "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> +{ "tx_packets", VIRTNET_NETDEV_S

Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-24 Thread Stephen Hemminger
On Wed, 20 Dec 2017 13:40:37 +0900 Toshiaki Makita wrote: > + > +static const struct virtnet_gstats virtnet_gstrings_stats[] = { > + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, > + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, > + { "rx_bytes", VI

Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-20 Thread Toshiaki Makita
On 2017/12/20 17:13, Jason Wang wrote: > On 2017年12月20日 12:40, Toshiaki Makita wrote: >> The main purpose of this patch is adding a way of checking per-queue >> stats. >> It's useful to debug performance problems on multiqueue environment. >> >> $ ethtool -S ens10 >> NIC statistics: >>   rx_pac

Re: [PATCH net-next] virtio_net: Add ethtool stats

2017-12-20 Thread Jason Wang
On 2017年12月20日 12:40, Toshiaki Makita wrote: The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6

[PATCH net-next] virtio_net: Add ethtool stats

2017-12-19 Thread Toshiaki Makita
The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: