Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-25 Thread Jason Wang
On Mon, Dec 25, 2023 at 4:03 PM Michael S. Tsirkin wrote: > > On Mon, Dec 25, 2023 at 12:12:48PM +0800, Jason Wang wrote: > > On Fri, Dec 22, 2023 at 4:14 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Dec 22, 2023 at 10:35:07AM +0800, Jason Wang wrote: > > > > On Thu, Dec 21, 2023 at 11:06 PM

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-25 Thread Michael S. Tsirkin
On Mon, Dec 25, 2023 at 12:12:48PM +0800, Jason Wang wrote: > On Fri, Dec 22, 2023 at 4:14 PM Michael S. Tsirkin wrote: > > > > On Fri, Dec 22, 2023 at 10:35:07AM +0800, Jason Wang wrote: > > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > > > wrote: > > > > > > > > Heng Qi wrote: > > > > >

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
On Mon, Dec 25, 2023 at 2:45 PM Jason Wang wrote: > > On Mon, Dec 25, 2023 at 2:34 PM Jason Xing wrote: > > > > On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > > > > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing > > > wrote: > > > > > > > > Hello Jason, > > > > On Fri, Dec 22, 2023 at 1

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Wang
On Mon, Dec 25, 2023 at 2:44 PM Jason Wang wrote: > > On Mon, Dec 25, 2023 at 2:34 PM Jason Xing wrote: > > > > On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > > > > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing > > > wrote: > > > > > > > > Hello Jason, > > > > On Fri, Dec 22, 2023 at 1

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Wang
On Mon, Dec 25, 2023 at 2:34 PM Jason Xing wrote: > > On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing > > wrote: > > > > > > Hello Jason, > > > On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > > > > > > > On Thu, Dec 21, 2023 at 11:0

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
On Mon, Dec 25, 2023 at 12:14 PM Jason Wang wrote: > > On Mon, Dec 25, 2023 at 10:25 AM Jason Xing wrote: > > > > Hello Jason, > > On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > > > > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > > > wrote: > > > > > > > > Heng Qi wrote: > > > >

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Wang
On Mon, Dec 25, 2023 at 10:25 AM Jason Xing wrote: > > Hello Jason, > On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > > wrote: > > > > > > Heng Qi wrote: > > > > > > > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > > > He

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Wang
On Fri, Dec 22, 2023 at 4:14 PM Michael S. Tsirkin wrote: > > On Fri, Dec 22, 2023 at 10:35:07AM +0800, Jason Wang wrote: > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > > wrote: > > > > > > Heng Qi wrote: > > > > > > > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > > > Heng Q

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-24 Thread Jason Xing
Hello Jason, On Fri, Dec 22, 2023 at 10:36 AM Jason Wang wrote: > > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > wrote: > > > > Heng Qi wrote: > > > > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > > Heng Qi wrote: > > > >> virtio-net has two ways to switch napi_tx: one is thro

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-22 Thread Michael S. Tsirkin
On Fri, Dec 22, 2023 at 10:35:07AM +0800, Jason Wang wrote: > On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn > wrote: > > > > Heng Qi wrote: > > > > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > > Heng Qi wrote: > > > >> virtio-net has two ways to switch napi_tx: one is through the

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-21 Thread Jason Wang
On Thu, Dec 21, 2023 at 11:06 PM Willem de Bruijn wrote: > > Heng Qi wrote: > > > > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > > Heng Qi wrote: > > >> virtio-net has two ways to switch napi_tx: one is through the > > >> module parameter, and the other is through coalescing parameter > > >>

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-21 Thread Willem de Bruijn
Heng Qi wrote: > > > 在 2023/12/20 下午10:45, Willem de Bruijn 写道: > > Heng Qi wrote: > >> virtio-net has two ways to switch napi_tx: one is through the > >> module parameter, and the other is through coalescing parameter > >> settings (provided that the nic status is down). > >> > >> Sometimes we f

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-21 Thread Zhu Yanjun
在 2023/12/21 13:20, Heng Qi 写道: 在 2023/12/21 上午11:02, Zhu Yanjun 写道: 在 2023/12/20 16:07, Heng Qi 写道: virtio-net has two ways to switch napi_tx: one is through the module parameter, and the other is through coalescing parameter settings (provided that the nic status is down). Sometimes we f

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-20 Thread Heng Qi
在 2023/12/21 上午11:02, Zhu Yanjun 写道: 在 2023/12/20 16:07, Heng Qi 写道: virtio-net has two ways to switch napi_tx: one is through the module parameter, and the other is through coalescing parameter settings (provided that the nic status is down). Sometimes we face performance regression caused

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-20 Thread Heng Qi
在 2023/12/20 下午10:45, Willem de Bruijn 写道: Heng Qi wrote: virtio-net has two ways to switch napi_tx: one is through the module parameter, and the other is through coalescing parameter settings (provided that the nic status is down). Sometimes we face performance regression caused by napi_tx,

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-20 Thread Zhu Yanjun
在 2023/12/20 16:07, Heng Qi 写道: virtio-net has two ways to switch napi_tx: one is through the module parameter, and the other is through coalescing parameter settings (provided that the nic status is down). Sometimes we face performance regression caused by napi_tx, then we need to switch napi_t

Re: [PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-20 Thread Willem de Bruijn
Heng Qi wrote: > virtio-net has two ways to switch napi_tx: one is through the > module parameter, and the other is through coalescing parameter > settings (provided that the nic status is down). > > Sometimes we face performance regression caused by napi_tx, > then we need to switch napi_tx when

[PATCH net-next] virtio-net: switch napi_tx without downing nic

2023-12-20 Thread Heng Qi
virtio-net has two ways to switch napi_tx: one is through the module parameter, and the other is through coalescing parameter settings (provided that the nic status is down). Sometimes we face performance regression caused by napi_tx, then we need to switch napi_tx when debugging. However, the exi