Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Eric Dumazet
On 4/20/21 7:51 PM, Guenter Roeck wrote: > > sh does indeed fail, with the same symptoms as before, but so far I was not > able to track it down to a specific commit. The alpha failure is different, > though. It is a NULL pointer access. > > Anyway, testing ... > > The patch below does indee

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On 4/20/21 9:31 AM, Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 5:42 PM Guenter Roeck wrote: >> >> On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote: >>> On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote: On 4/20/21 2:43 AM, Eric Dumazet wrote: >>> > Unfortu

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote: > > > > On 4/20/21 2:43 AM, Eric Dumazet wrote: > > > > > > > > Unfortunately that doesn't fix the problem for me. With this patch applied > > on top of next-20210419, I still get

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On 4/20/21 2:43 AM, Eric Dumazet wrote: > From: Eric Dumazet > > KASAN/syzbot had 4 reports, one of them being: > > BUG: KASAN: slab-out-of-bounds in memcpy include/linux/fortify-string.h:191 > [inline] > BUG: KASAN: slab-out-of-bounds in page_to_skb+0x5cf/0xb70 > drivers/net/virtio_net.c:480

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Michael S. Tsirkin
On Tue, Apr 20, 2021 at 02:43:41AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > KASAN/syzbot had 4 reports, one of them being: > > BUG: KASAN: slab-out-of-bounds in memcpy include/linux/fortify-string.h:191 > [inline] > BUG: KASAN: slab-out-of-bounds in page_to_skb+0x5cf/0xb70 > drivers

[PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Eric Dumazet
From: Eric Dumazet KASAN/syzbot had 4 reports, one of them being: BUG: KASAN: slab-out-of-bounds in memcpy include/linux/fortify-string.h:191 [inline] BUG: KASAN: slab-out-of-bounds in page_to_skb+0x5cf/0xb70 drivers/net/virtio_net.c:480 Read of size 12 at addr 888014a5f800 by task systemd