Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 16:02 +0100, Paolo Abeni wrote: > > No problem at all with incremental patches ;-) > > In our experiment, touching udp_memory_allocated is only a part of the > the source of contention, with the biggest source of contention being > the sk_rmem_alloc update - which happens o

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-31 Thread Paolo Abeni
On Sat, 2016-10-29 at 05:43 -0700, Eric Dumazet wrote: > On Sat, 2016-10-29 at 10:17 +0200, Paolo Abeni wrote: > > > Thank you for working on this. > > > > I just gave a very quick look (the WE has started, children are > > screaming ;-), overall the implementation seems quite similar to our > >

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-29 Thread Eric Dumazet
On Sat, 2016-10-29 at 10:17 +0200, Paolo Abeni wrote: > Thank you for working on this. > > I just gave a very quick look (the WE has started, children are > screaming ;-), overall the implementation seems quite similar to our > one. > > I like the additional argument to ip_cmsg_recv_offset() i

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-29 Thread Paolo Abeni
On Fri, 2016-10-28 at 10:50 -0700, Eric Dumazet wrote: > On Fri, 2016-10-28 at 10:16 -0700, Eric Dumazet wrote: > > Nice ! > > > > I was working on this as well and my implementation was somewhat > > different. > > This is my WIP > > Note this can be split in two parts. > > 1) One adding struct

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-28 Thread Eric Dumazet
On Fri, 2016-10-28 at 10:16 -0700, Eric Dumazet wrote: > Nice ! > > I was working on this as well and my implementation was somewhat > different. This is my WIP Note this can be split in two parts. 1) One adding struct sock *sk param to ip_cmsg_recv_offset() This was because I left skb->sk

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-28 Thread Eric Dumazet
Nice ! I was working on this as well and my implementation was somewhat different. I then stopped when I found the UDP checksum bug and was waiting for net to be merged into net-next ( https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=10df8e6152c6c400a563a673e9956320bfce1871

[PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-28 Thread Paolo Abeni
A new argument is added to __skb_recv_datagram, it allows the caller to perform protocol specific action on dequeue under the receive queue spinlock. The UDP protocol uses such argument to perform fwd memory reclaiming on dequeue, while protocol memory and rmem updatating is delayed after the lock