Re: [PATCH net-next] tun: fix memory leak in error path

2019-10-08 Thread Jakub Kicinski
On Tue, 8 Oct 2019 12:47:56 -0700, Eric Dumazet wrote: > On Tue, Oct 8, 2019 at 12:31 PM Jakub Kicinski wrote: > > On Mon, 7 Oct 2019 12:21:05 -0700, Eric Dumazet wrote: > > > syzbot reported a warning [1] that triggered after recent Jiri patch. > > > > > > This exposes a bug that we hit already

Re: [PATCH net-next] tun: fix memory leak in error path

2019-10-08 Thread Eric Dumazet
On Tue, Oct 8, 2019 at 12:31 PM Jakub Kicinski wrote: > > On Mon, 7 Oct 2019 12:21:05 -0700, Eric Dumazet wrote: > > syzbot reported a warning [1] that triggered after recent Jiri patch. > > > > This exposes a bug that we hit already in the past (see commit > > ff244c6b29b1 ("tun: handle register

Re: [PATCH net-next] tun: fix memory leak in error path

2019-10-08 Thread Jakub Kicinski
On Mon, 7 Oct 2019 12:21:05 -0700, Eric Dumazet wrote: > syzbot reported a warning [1] that triggered after recent Jiri patch. > > This exposes a bug that we hit already in the past (see commit > ff244c6b29b1 ("tun: handle register_netdevice() failures properly") > for details) > > tun uses priv

[PATCH net-next] tun: fix memory leak in error path

2019-10-07 Thread Eric Dumazet
syzbot reported a warning [1] that triggered after recent Jiri patch. This exposes a bug that we hit already in the past (see commit ff244c6b29b1 ("tun: handle register_netdevice() failures properly") for details) tun uses priv->destructor without an ndo_init() method. register_netdevice() can r