From: Eric Dumazet
Date: Thu, 04 Jun 2015 08:01:12 -0700
> From: Eric Dumazet
>
> For same reasons than in commit 12e25e1041d0 ("tcp: remove redundant
> checks"), we can remove redundant checks done for timewait sockets.
>
> Signed-off-by: Eric Dumazet
Applied, thanks Eric.
--
To unsubscribe
From: Eric Dumazet
For same reasons than in commit 12e25e1041d0 ("tcp: remove redundant
checks"), we can remove redundant checks done for timewait sockets.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_ipv4.c |4
net/ipv6/tcp_ipv6.c |4
2 files changed, 8 deletions(-)
diff --
From: Eric Dumazet
Date: Wed, 03 Jun 2015 23:49:21 -0700
> From: Eric Dumazet
>
> tcp_v4_rcv() checks the following before calling tcp_v4_do_rcv():
>
> if (th->doff < sizeof(struct tcphdr) / 4)
> goto bad_packet;
> if (!pskb_may_pull(skb, th->doff * 4))
> goto discard_it;
>
> So foll
From: Eric Dumazet
tcp_v4_rcv() checks the following before calling tcp_v4_do_rcv():
if (th->doff < sizeof(struct tcphdr) / 4)
goto bad_packet;
if (!pskb_may_pull(skb, th->doff * 4))
goto discard_it;
So following check in tcp_v4_do_rcv() is redundant
and "goto csum_err;" is wrong anywa
