Re: [PATCH net-next] tcp: remove redundant SOCK_DONE checks

2018-07-08 Thread David Miller
From: Eric Dumazet Date: Sat, 7 Jul 2018 23:15:56 -0700 > In both tcp_splice_read() and tcp_recvmsg(), we already test > sock_flag(sk, SOCK_DONE) right before evaluating sk->sk_state, > so "!sock_flag(sk, SOCK_DONE)" is always true. > > Signed-off-by: Eric Dumazet Wow, I think this code has b

[PATCH net-next] tcp: remove redundant SOCK_DONE checks

2018-07-07 Thread Eric Dumazet
In both tcp_splice_read() and tcp_recvmsg(), we already test sock_flag(sk, SOCK_DONE) right before evaluating sk->sk_state, so "!sock_flag(sk, SOCK_DONE)" is always true. Signed-off-by: Eric Dumazet --- net/ipv4/tcp.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --g