Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-25 Thread David Miller
From: Eric Dumazet Date: Wed, 24 Aug 2016 09:01:23 -0700 > From: Eric Dumazet > > Adds SNMP counter for drops caused by MD5 mismatches. > > The current syslog might help, but a counter is more precise and helps > monitoring. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Stephen Hemminger
On Wed, 24 Aug 2016 09:01:23 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > Adds SNMP counter for drops caused by MD5 mismatches. > > The current syslog might help, but a counter is more precise and helps > monitoring. > > Signed-off-by: Eric Dumazet > --- > include/uapi/linux/snmp.h |

Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Eric Dumazet
On Wed, 2016-08-24 at 10:35 -0700, Stephen Hemminger wrote: > You can't add value in middle of user API enum without breaking > binary compatibility. There is no binary compatibility here. /proc/net/netstat is a text file with a defined format. First line contains the headers. If 'binary compa

[PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter

2016-08-24 Thread Eric Dumazet
From: Eric Dumazet Adds SNMP counter for drops caused by MD5 mismatches. The current syslog might help, but a counter is more precise and helps monitoring. Signed-off-by: Eric Dumazet --- include/uapi/linux/snmp.h |1 + net/ipv4/proc.c |1 + net/ipv4/tcp_ipv4.c |1