Re: [PATCH net-next] tcp: fix tcp_xmit_retransmit_queue() after rbtree introduction

2017-10-18 Thread David Miller
From: Eric Dumazet Date: Mon, 16 Oct 2017 19:38:35 -0700 > From: Eric Dumazet > > I tried to hard avoiding a call to rb_first() (via tcp_rtx_queue_head) > in tcp_xmit_retransmit_queue(). But this was probably too bold. > > Quoting Yuchung : > > We might miss re-arming the RTO if tp->retransmi

[PATCH net-next] tcp: fix tcp_xmit_retransmit_queue() after rbtree introduction

2017-10-16 Thread Eric Dumazet
From: Eric Dumazet I tried to hard avoiding a call to rb_first() (via tcp_rtx_queue_head) in tcp_xmit_retransmit_queue(). But this was probably too bold. Quoting Yuchung : We might miss re-arming the RTO if tp->retransmit_skb_hint is not NULL. This can happen when RACK marks the first packet lo