Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-24 Thread Eric Dumazet
On Thu, 2016-11-24 at 15:42 -0500, David Miller wrote: > From: Eric Dumazet > Date: Tue, 22 Nov 2016 10:57:33 -0800 > > > David, patch is marked 'Superseded' in > > https://patchwork.ozlabs.org/patch/695264/ > > > > Not sure what this means exactly ? > > Did I miss a mail/feedback/something ? >

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-24 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Nov 2016 10:57:33 -0800 > David, patch is marked 'Superseded' in > https://patchwork.ozlabs.org/patch/695264/ > > Not sure what this means exactly ? > Did I miss a mail/feedback/something ? I must have mistakenly marked it that way, sorry. Applied to net-next,

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-23 Thread Yuchung Cheng
On Tue, Nov 15, 2016 at 12:51 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), > we made a first step allowing copying right skb to left skb head. > > Since all skbs in socket write queue are headless (but possibly the very > first one), t

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-15 at 12:51 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), > we made a first step allowing copying right skb to left skb head. > > Since all skbs in socket write queue are headless (but possibly the very > first one), t

[PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-15 Thread Eric Dumazet
From: Eric Dumazet In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), we made a first step allowing copying right skb to left skb head. Since all skbs in socket write queue are headless (but possibly the very first one), this strategy often does not work. This patch extends tcp_collapse_re