Re: [PATCH net-next] tcp: add optional per socket transmit delay

2019-06-12 Thread Eric Dumazet
On Wed, Jun 12, 2019 at 11:21 AM David Miller wrote: > > From: David Miller > Date: Wed, 12 Jun 2019 11:03:44 -0700 (PDT) > > > Applied to net-next and build testing. > > Missing symbol export it seems... > > ERROR: "tcp_tx_delay_enabled" [net/ipv6/ipv6.ko] undefined! > make[1]: *** [scripts/Make

Re: [PATCH net-next] tcp: add optional per socket transmit delay

2019-06-12 Thread David Miller
From: David Miller Date: Wed, 12 Jun 2019 11:03:44 -0700 (PDT) > Applied to net-next and build testing. Missing symbol export it seems... ERROR: "tcp_tx_delay_enabled" [net/ipv6/ipv6.ko] undefined! make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1

Re: [PATCH net-next] tcp: add optional per socket transmit delay

2019-06-12 Thread David Miller
From: Eric Dumazet Date: Mon, 10 Jun 2019 20:03:34 -0700 > Adding delays to TCP flows is crucial for studying behavior > of TCP stacks, including congestion control modules. > > Linux offers netem module, but it has unpractical constraints : > - Need root access to change qdisc > - Hard to setup

Re: [PATCH net-next] tcp: add optional per socket transmit delay

2019-06-11 Thread Eric Dumazet
On Tue, Jun 11, 2019 at 12:16 PM David Miller wrote: > > From: Eric Dumazet > Date: Mon, 10 Jun 2019 20:03:34 -0700 > > > This patchs adds TCP_TX_DELAY socket option, to set a delay in > > usec units. > > > > unsigned int tx_delay = 1; /* 10 msec */ > > > > setsockopt(fd, SOL_TCP, TCP_TX_

Re: [PATCH net-next] tcp: add optional per socket transmit delay

2019-06-11 Thread David Miller
From: Eric Dumazet Date: Mon, 10 Jun 2019 20:03:34 -0700 > This patchs adds TCP_TX_DELAY socket option, to set a delay in > usec units. > > unsigned int tx_delay = 1; /* 10 msec */ > > setsockopt(fd, SOL_TCP, TCP_TX_DELAY, &tx_delay, sizeof(tx_delay)); I'm trying to think about what th

[PATCH net-next] tcp: add optional per socket transmit delay

2019-06-10 Thread Eric Dumazet
Adding delays to TCP flows is crucial for studying behavior of TCP stacks, including congestion control modules. Linux offers netem module, but it has unpractical constraints : - Need root access to change qdisc - Hard to setup on egress if combined with non trivial qdisc like FQ - Single delay fo