Re: [PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

2016-12-02 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 30 Nov 2016 14:01:08 -0500 > From: Soheil Hassas Yeganeh > > Only when ICMP packets are enqueued onto the error queue, > sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err > in sock_dequeue_err_skb), a subsequent error queue read > would set

Re: [PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

2016-11-30 Thread Maciej Żenczykowski
On Wed, Nov 30, 2016 at 8:01 PM, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Only when ICMP packets are enqueued onto the error queue, > sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err > in sock_dequeue_err_skb), a subsequent error queue read > would set sk_err

Re: [PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

2016-11-30 Thread Eric Dumazet
On Wed, 2016-11-30 at 14:01 -0500, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Only when ICMP packets are enqueued onto the error queue, > sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err > in sock_dequeue_err_skb), a subsequent error queue read > would set sk_e

[PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

2016-11-30 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Only when ICMP packets are enqueued onto the error queue, sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err in sock_dequeue_err_skb), a subsequent error queue read would set sk_err to the next error on the queue, or 0 if empty. As no error types other th