Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-07 Thread David Miller
From: Soheil Hassas Yeganeh Date: Thu, 3 Nov 2016 18:24:27 -0400 > From: Soheil Hassas Yeganeh > > Do not set sk_err when dequeuing errors from the error queue. > Doing so results in: > a) Bugs: By overwriting existing sk_err values, it possibly >hides legitimate errors. It is also incorre

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-06 Thread Andy Lutomirski
On Nov 4, 2016 1:26 PM, "Willem de Bruijn" wrote: > > On Thu, Nov 3, 2016 at 7:10 PM, Hannes Frederic Sowa > wrote: > > [also cc'ed Andy, albeit this doesn't seem to solve his initial problem, > > right? ] > > Indeed, this does not help disambig

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-04 Thread Willem de Bruijn
On Thu, Nov 3, 2016 at 7:10 PM, Hannes Frederic Sowa wrote: > [also cc'ed Andy, albeit this doesn't seem to solve his initial problem, > right? ] Indeed, this does not help disambiguate the source of an error returned by a socketcall. It only re

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-03 Thread Hannes Frederic Sowa
[also cc'ed Andy, albeit this doesn't seem to solve his initial problem, right? ] On 03.11.2016 23:24, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Do not set sk_err when dequeuing errors from the error queue. > Doing so resul

[PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-03 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Do not set sk_err when dequeuing errors from the error queue. Doing so results in: a) Bugs: By overwriting existing sk_err values, it possibly hides legitimate errors. It is also incorrect when local errors are queued with ip_local_error. That happens in the c