Re: [PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread David Miller
From: Paolo Abeni Date: Thu, 30 Mar 2017 14:03:06 +0200 > sock_recv_ts_and_drops() unconditionally set sk->sk_stamp for > every packet, even if the SOCK_TIMESTAMP flag is not set in the > related socket. > If selinux is enabled, this cause a cache miss for every packet > since sk->sk_stamp and sk

Re: [PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread Eric Dumazet
On Thu, 2017-03-30 at 16:23 +0200, Paolo Abeni wrote: > That way, if the net timestamp is enable, we will record the timestamp > of the first packet received by the socket (it can be far away in the > past). > I think is just a different kind of approximation. I see. This (64bit) sk_stamp stuff

Re: [PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread Paolo Abeni
On Thu, 2017-03-30 at 06:52 -0700, Eric Dumazet wrote: > On Thu, 2017-03-30 at 14:03 +0200, Paolo Abeni wrote: > > sock_recv_ts_and_drops() unconditionally set sk->sk_stamp for > > every packet, even if the SOCK_TIMESTAMP flag is not set in the > > related socket. > > If selinux is enabled, this ca

Re: [PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread Eric Dumazet
On Thu, 2017-03-30 at 14:03 +0200, Paolo Abeni wrote: > sock_recv_ts_and_drops() unconditionally set sk->sk_stamp for > every packet, even if the SOCK_TIMESTAMP flag is not set in the > related socket. > If selinux is enabled, this cause a cache miss for every packet > since sk->sk_stamp and sk->sk

[PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread Paolo Abeni
sock_recv_ts_and_drops() unconditionally set sk->sk_stamp for every packet, even if the SOCK_TIMESTAMP flag is not set in the related socket. If selinux is enabled, this cause a cache miss for every packet since sk->sk_stamp and sk->sk_security share the same cacheline. With this change sk_stamp is