Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-15 Thread Jakub Kicinski
On Wed, 16 Dec 2020 02:08:34 +0100 Andrea Mayer wrote: > I agree with this approach. Only for the sake of clarity I would prefer to > define the macro SEG6_LOCAL_MAX_SUPP as follows: > > in seg6_local.c: > [...] > > /* max total number of supported SRv6 behavior attributes */ > #define SEG6_LO

Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-15 Thread Andrea Mayer
Hi Jakub, thanks for your review. On Mon, 14 Dec 2020 20:57:40 -0800 Jakub Kicinski wrote: > > > > - At compile time we verify that the total number of attributes does not > >exceed the fixed value of 64. Otherwise, kernel build fails forcing > >developers to reconsider adding a new at

Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 02:00:05 +0100 Andrea Mayer wrote: > The set of required attributes for a given SRv6 behavior is identified > using a bitmap stored in an unsigned long, since the initial design of > SRv6 networking in Linux. Recently the same approach has been used for > identifying the optiona

[PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-11 Thread Andrea Mayer
The set of required attributes for a given SRv6 behavior is identified using a bitmap stored in an unsigned long, since the initial design of SRv6 networking in Linux. Recently the same approach has been used for identifying the optional attributes. We realized that choosing an unsigned long to st