Re: [PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero

2017-04-28 Thread Florian Fainelli
On 04/28/2017 07:14 AM, David Miller wrote: > From: Herbert Xu > Date: Fri, 28 Apr 2017 14:10:48 +0800 > >> The commit 6d684e54690c ("rhashtable: Cap total number of entries >> to 2^31") breaks rhashtable users that do not set max_size. This >> is because when max_size is zero max_elems is also

Re: [PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero

2017-04-28 Thread David Miller
From: Herbert Xu Date: Fri, 28 Apr 2017 14:10:48 +0800 > The commit 6d684e54690c ("rhashtable: Cap total number of entries > to 2^31") breaks rhashtable users that do not set max_size. This > is because when max_size is zero max_elems is also incorrectly set > to zero instead of 2^31. > > This

[PATCH net-next] rhashtable: Do not lower max_elems when max_size is zero

2017-04-27 Thread Herbert Xu
On Thu, Apr 27, 2017 at 03:30:24PM -0700, Florian Fainelli wrote: > After commit 6d684e54690c ("rhashtable: Cap total number of > entries to 2^31"), we would be hitting a panic() in net/core/rtnetlink.c > during initialization. The call stack would look like this: Thanks for the patch. I think we