Re: [PATCH net-next] remove TWKilled counter

2019-01-27 Thread peng yu
Hi, David and Cong I don't quite understand where this patch to go. This patch wants to delete the LINUX_MIB_TIMEWAITKILLED counter. Moving snmp.h out of the uapi directory is a difference thing. Do we really need to do it? On Tue, Jan 22, 2019 at 10:58 PM Cong Wang wrote: > > On Mon, Jan 21, 20

Re: [PATCH net-next] remove TWKilled counter

2019-01-22 Thread Cong Wang
On Mon, Jan 21, 2019 at 3:14 PM peng yu wrote: > > Hello, I think the snmp.h didn't try to keep user-space compatibility, > so we could delete LINUX_MIB_TIMEWAITKILLED counter. Do I > misunderstand anything? I don't know. Maybe user-space doesn't need these definitions at all, as like nstat can

Re: [PATCH net-next] remove TWKilled counter

2019-01-21 Thread peng yu
Hello, I think the snmp.h didn't try to keep user-space compatibility, so we could delete LINUX_MIB_TIMEWAITKILLED counter. Do I misunderstand anything? On Thu, Jan 17, 2019 at 12:26 PM peng yu wrote: > > On Thu, Jan 17, 2019 at 10:07 AM Cong Wang wrote: > > > > On Thu, Jan 17, 2019 at 3:43 AM

Re: [PATCH net-next] remove TWKilled counter

2019-01-17 Thread peng yu
On Thu, Jan 17, 2019 at 10:07 AM Cong Wang wrote: > > On Thu, Jan 17, 2019 at 3:43 AM yupeng wrote: > > diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h > > index 86dc24a96c90..fb0a17337bf2 100644 > > --- a/include/uapi/linux/snmp.h > > +++ b/include/uapi/linux/snmp.h > > @@ -17

Re: [PATCH net-next] remove TWKilled counter

2019-01-17 Thread Cong Wang
On Thu, Jan 17, 2019 at 3:43 AM yupeng wrote: > diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h > index 86dc24a96c90..fb0a17337bf2 100644 > --- a/include/uapi/linux/snmp.h > +++ b/include/uapi/linux/snmp.h > @@ -178,7 +178,6 @@ enum > LINUX_MIB_ARPFILTER,

[PATCH net-next] remove TWKilled counter

2019-01-17 Thread yupeng
The most possible way to trigger TWKilled is using tcp_tw_recycle, but tcp_tw_recycle was removed. The TWKilled could still be triggered if below conditions are satisfied: 1 the tw_timer expires in fin_wait_2 status 2 the timeout value of tw_timer is changed to less than 4 seconds (via net.ipv4.t