Re: [PATCH net-next] rds: cancel send/recv work before queuing connection shutdown

2017-07-16 Thread David Miller
From: Sowmini Varadhan Date: Sun, 16 Jul 2017 16:43:46 -0700 > We could end up executing rds_conn_shutdown before the rds_recv_worker > thread, then rds_conn_shutdown -> rds_tcp_conn_shutdown can do a > sock_release and set sock->sk to null, which may interleave in bad > ways with rds_recv_worker

[PATCH net-next] rds: cancel send/recv work before queuing connection shutdown

2017-07-16 Thread Sowmini Varadhan
We could end up executing rds_conn_shutdown before the rds_recv_worker thread, then rds_conn_shutdown -> rds_tcp_conn_shutdown can do a sock_release and set sock->sk to null, which may interleave in bad ways with rds_recv_worker, e.g., it could result in: "BUG: unable to handle kernel NULL pointer