Re: [PATCH net-next] r8169: factor out PHY init sequence adjusting 10M and ALDPS

2019-01-24 Thread David Miller
From: Heiner Kallweit Date: Wed, 23 Jan 2019 20:47:30 +0100 > Few chip versions use the same sequence to adjust 10M and ALDPS, so > let's factor it out. This patch also fixes a (most likely) typo in > rtl8168g_1_hw_phy_config. There bit 8 in reg 0x14 on page 0x0bcc > was set and not cleared. Acco

[PATCH net-next] r8169: factor out PHY init sequence adjusting 10M and ALDPS

2019-01-23 Thread Heiner Kallweit
Few chip versions use the same sequence to adjust 10M and ALDPS, so let's factor it out. This patch also fixes a (most likely) typo in rtl8168g_1_hw_phy_config. There bit 8 in reg 0x14 on page 0x0bcc was set and not cleared. According to the vendor driver this bit needs to be cleared in all cases.