Re: [PATCH net-next] r8152: Add identifier names for function pointers

2019-10-03 Thread David Miller
From: Prashant Malani Date: Wed, 2 Oct 2019 14:09:33 -0700 > Checkpatch throws warnings for function pointer declarations which lack > identifier names. > > An example of such a warning is: > > WARNING: function definition argument 'struct r8152 *' should > also have an identifier name > 739:

RE: [PATCH net-next] r8152: Add identifier names for function pointers

2019-10-02 Thread Hayes Wang
Prashant Malani [mailto:pmal...@chromium.org] > Sent: Thursday, October 03, 2019 5:10 AM > To: Hayes Wang > Cc: grund...@chromium.org; netdev@vger.kernel.org; nic_swsd; Prashant > Malani > Subject: [PATCH net-next] r8152: Add identifier names for function pointers > > Check

[PATCH net-next] r8152: Add identifier names for function pointers

2019-10-02 Thread Prashant Malani
Checkpatch throws warnings for function pointer declarations which lack identifier names. An example of such a warning is: WARNING: function definition argument 'struct r8152 *' should also have an identifier name 739: FILE: drivers/net/usb/r8152.c:739: + void (*init)(struct r8152 *