Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Weidong Wang
On 2016/4/14 2:41, Florian Fainelli wrote: > On 13/04/16 04:59, Weidong Wang wrote: >> When tested the PHY SGMII Loopback,: >> 1.set the LOOPBACK bit, >> 2.set the autoneg to AUTONEG_DISABLE, it calls the >> genphy_setup_forced which will clear the bit. >> >> So just keep the LOOPBACK bit while set

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Weidong Wang
On 2016/4/13 22:19, Sergei Shtylyov wrote: > Hello. > > On 4/13/2016 2:59 PM, Weidong Wang wrote: > >> When tested the PHY SGMII Loopback,: >> 1.set the LOOPBACK bit, >> 2.set the autoneg to AUTONEG_DISABLE, it calls the >> genphy_setup_forced which will clear the bit. >> >> So just keep the LOOP

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Florian Fainelli
On 13/04/16 04:59, Weidong Wang wrote: > When tested the PHY SGMII Loopback,: > 1.set the LOOPBACK bit, > 2.set the autoneg to AUTONEG_DISABLE, it calls the > genphy_setup_forced which will clear the bit. > > So just keep the LOOPBACK bit while setup forced mode. Humm, it makes sense why we want

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Sergei Shtylyov
Hello. On 4/13/2016 2:59 PM, Weidong Wang wrote: When tested the PHY SGMII Loopback,: 1.set the LOOPBACK bit, 2.set the autoneg to AUTONEG_DISABLE, it calls the genphy_setup_forced which will clear the bit. So just keep the LOOPBACK bit while setup forced mode. Signed-off-by: Weidong Wang --

[RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Weidong Wang
When tested the PHY SGMII Loopback,: 1.set the LOOPBACK bit, 2.set the autoneg to AUTONEG_DISABLE, it calls the genphy_setup_forced which will clear the bit. So just keep the LOOPBACK bit while setup forced mode. Signed-off-by: Weidong Wang --- drivers/net/phy/phy_device.c | 2 ++ 1 file change

[PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-03-24 Thread Weidong Wang
When tested the PHY SGMII Loopback,: 1.set the LOOPBACK bit, 2.set the autoneg to AUTONEG_DISABLE, it calls the genphy_setup_forced which will clear the bit. So just keep the LOOPBACK bit while setup forced mode. Signed-off-by: Weidong Wang --- drivers/net/phy/phy_device.c | 2 ++ 1 file change