Re: [ovs-dev] [PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread pravin shelar
On Wed, Mar 9, 2016 at 4:25 PM, Samuel Gauthier wrote: > Sorry, I missed that. Thank you for pointing it out. > > Although, set command is also used to reset the flow statistics, and the > action attribute seems optional. Would you find acceptable to make the key > attribute mandatory only if the

Re: [ovs-dev] [PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread pravin shelar
On Wed, Mar 9, 2016 at 9:05 AM, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow > key in the netlink message. W

[PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread Samuel Gauthier
When we want to change a flow using netlink, we have to identify it to be able to perform a lookup. Both the flow key and unique flow ID (ufid) are valid identifiers, but we always have to specify the flow key in the netlink message. When both attributes are there, the ufid is used. This commit al