Re: [PATCH net-next] openvswitch: Print error when ovs_execute_actions() fails

2019-08-04 Thread Yifeng Sun
Yes, this fix is mainly for debugging purposes. If packets are blackholed because of errors from ovs_execute_actions(), we can got more helpful information. Thanks Pravin for the review, I will come up with a new version. Yifeng On Sat, Aug 3, 2019 at 4:00 PM Pravin Shelar wrote: > > On Thu, Aug

Re: [PATCH net-next] openvswitch: Print error when ovs_execute_actions() fails

2019-08-03 Thread Pravin Shelar
On Thu, Aug 1, 2019 at 2:14 PM Yifeng Sun wrote: > > Currently in function ovs_dp_process_packet(), return values of > ovs_execute_actions() are silently discarded. This patch prints out > an error message when error happens so as to provide helpful hints > for debugging. > > Signed-off-by: Yifeng

Re: [PATCH net-next] openvswitch: Print error when ovs_execute_actions() fails

2019-08-02 Thread Gregory Rose
On 8/1/2019 2:14 PM, Yifeng Sun wrote: Currently in function ovs_dp_process_packet(), return values of ovs_execute_actions() are silently discarded. This patch prints out an error message when error happens so as to provide helpful hints for debugging. Signed-off-by: Yifeng Sun --- net/openvs

[PATCH net-next] openvswitch: Print error when ovs_execute_actions() fails

2019-08-01 Thread Yifeng Sun
Currently in function ovs_dp_process_packet(), return values of ovs_execute_actions() are silently discarded. This patch prints out an error message when error happens so as to provide helpful hints for debugging. Signed-off-by: Yifeng Sun --- net/openvswitch/datapath.c | 7 +-- 1 file chang