Re: [PATCH net-next] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Jakub Kicinski
On Fri, 13 Nov 2020 10:47:30 +0900 Bongsu Jeon wrote: > Add driver for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: bongsujeon I think you've only read my first review comment, there is more comments inline in my reply.

[PATCH net-next] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-12 Thread Bongsu Jeon
Add driver for Samsung S3FWRN82 NFC controller. S3FWRN82 is using NCI protocol and I2C communication interface. Signed-off-by: bongsujeon --- .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 ++ drivers/nfc/Kconfig | 1 + drivers/nfc/Makefile