Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Tue, Dec 1, 2020 at 6:38 PM Jakub Kicinski wrote: > > On Tue, 1 Dec 2020 12:24:38 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > On Thu, Nov 19, 2020 at 8:56 PM Jakub Kicinski wrote: > > > Do you have more details on what the use cases are that expect no > > > networking? > > > > > > TBH I do

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Tue, 1 Dec 2020 12:24:38 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Nov 19, 2020 at 8:56 PM Jakub Kicinski wrote: > > Do you have more details on what the use cases are that expect no > > networking? > > > > TBH I don't get the utility of this knob. If you want to write vaguely > > p

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Thu, Nov 19, 2020 at 8:56 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 19:55:08 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > On Thu, Nov 19, 2020 at 12:03 AM Nicolas Dichtel > > > Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > > > > netns but would create problems for

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Thu, 19 Nov 2020 19:55:08 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Nov 19, 2020 at 12:03 AM Nicolas Dichtel > > Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > > > netns but would create problems for workloads that create netns to > > > disable networking. One ca

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Thu, Nov 19, 2020 at 12:03 AM Nicolas Dichtel wrote: > > Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > > wrote: > >> > >> Le 18/11/2020 à 02:12, David Ahern a écrit : > >> [snip] > >>> If there is no harm in just creating

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > wrote: >> >> Le 18/11/2020 à 02:12, David Ahern a écrit : >> [snip] >>> If there is no harm in just creating lo in the up state, why not just do >>> it vs relying on a sysctl? It onl

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Wed, Nov 18, 2020 at 10:04 AM David Ahern wrote: > > On 11/18/20 10:39 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > > wrote: > >> > >> Le 18/11/2020 à 02:12, David Ahern a écrit : > >> [snip] > >>> If there is no harm in just creating lo in th

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On 11/18/20 10:39 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > wrote: >> >> Le 18/11/2020 à 02:12, David Ahern a écrit : >> [snip] >>> If there is no harm in just creating lo in the up state, why not just do >>> it vs relying on a sysctl? It only af

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel wrote: > > Le 18/11/2020 à 02:12, David Ahern a écrit : > [snip] > > If there is no harm in just creating lo in the up state, why not just do > > it vs relying on a sysctl? It only affects 'local' networking so no real > > impact to containers that d

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

Le 18/11/2020 à 02:12, David Ahern a écrit : [snip] > If there is no harm in just creating lo in the up state, why not just do > it vs relying on a sysctl? It only affects 'local' networking so no real > impact to containers that do not do networking (ie., packets can't > escape). Linux has a lot o

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On 11/17/20 1:53 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Tue, Nov 17, 2020 at 9:18 AM Ido Schimmel wrote: >> >> On Mon, Nov 16, 2020 at 01:03:32PM -0800, Mahesh Bandewar (महेश बंडेवार) >> wrote: >>> On Mon, Nov 16, 2020 at 12:34 PM Jakub Kicinski wrote: On Mon, 16 Nov 2020 12:02

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Tue, Nov 17, 2020 at 9:18 AM Ido Schimmel wrote: > > On Mon, Nov 16, 2020 at 01:03:32PM -0800, Mahesh Bandewar (महेश बंडेवार) > wrote: > > On Mon, Nov 16, 2020 at 12:34 PM Jakub Kicinski wrote: > > > > > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > > > > di

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, Nov 16, 2020 at 01:03:32PM -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Nov 16, 2020 at 12:34 PM Jakub Kicinski wrote: > > > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > > > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > > > > >

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

Hi Jian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jian-Yang/net-loopback-allow-lo-dev-initial-state-to-be-controlled/20201112-044539 base: https://git.kernel.org/pub/scm/linux/kernel/git/dave

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, Nov 16, 2020 at 1:20 PM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 12:50:22 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > On Mon, Nov 16, 2020 at 12:17 PM Jakub Kicinski wrote: > > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > > On Sat, Nov 14, 2020

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, 16 Nov 2020 12:50:22 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Nov 16, 2020 at 12:17 PM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > On Sat, Nov 14, 2020 at 10:17 AM Jakub Kicinski wrote: > > > > On Wed, 11 Nov 20

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, Nov 16, 2020 at 12:34 PM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > > > > index a1c77cc00416..76dc92ac65a2 100644 > > > > --- a/drivers/net/loopback.c > > > > +++

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, Nov 16, 2020 at 12:17 PM Jakub Kicinski wrote: > > On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > On Sat, Nov 14, 2020 at 10:17 AM Jakub Kicinski wrote: > > > On Wed, 11 Nov 2020 12:43:08 -0800 Jian Yang wrote: > > > > From: Mahesh Bandewar > > > > > > > > T

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > > > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > > > index a1c77cc00416..76dc92ac65a2 100644 > > > --- a/drivers/net/loopback.c > > > +++ b/drivers/net/loopback.c > > > @@ -219,6 +219,13 @@ static __net_ini

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Mon, 16 Nov 2020 12:02:48 -0800 Mahesh Bandewar (महेश बंडेवार) wrote: > On Sat, Nov 14, 2020 at 10:17 AM Jakub Kicinski wrote: > > On Wed, 11 Nov 2020 12:43:08 -0800 Jian Yang wrote: > > > From: Mahesh Bandewar > > > > > > Traditionally loopback devices comes up with initial state as DOWN fo

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Sat, Nov 14, 2020 at 10:17 AM Jakub Kicinski wrote: > > On Wed, 11 Nov 2020 12:43:08 -0800 Jian Yang wrote: > > From: Mahesh Bandewar > > > > Traditionally loopback devices comes up with initial state as DOWN for > > any new network-namespace. This would mean that anyone needing this > > devic

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Wed, 11 Nov 2020 12:43:08 -0800 Jian Yang wrote: > From: Mahesh Bandewar > > Traditionally loopback devices comes up with initial state as DOWN for > any new network-namespace. This would mean that anyone needing this > device (which is mostly true except sandboxes where networking in not > ne

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Thu, 2020-11-12 at 17:08 +0100, Andrew Lunn wrote: > On Wed, Nov 11, 2020 at 12:43:08PM -0800, Jian Yang wrote: > > From: Mahesh Bandewar > > > > Traditionally loopback devices comes up with initial state as DOWN > > for > > any new network-namespace. This would mean that anyone needing this >

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

On Wed, Nov 11, 2020 at 12:43:08PM -0800, Jian Yang wrote: > From: Mahesh Bandewar > > Traditionally loopback devices comes up with initial state as DOWN for > any new network-namespace. This would mean that anyone needing this > device (which is mostly true except sandboxes where networking in n

[PATCH net-next] net-loopback: allow lo dev initial state to be controlled

From: Mahesh Bandewar Traditionally loopback devices comes up with initial state as DOWN for any new network-namespace. This would mean that anyone needing this device (which is mostly true except sandboxes where networking in not needed at all), would have to bring this UP by issuing something l