Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-07 Thread Jakub Kicinski
On Fri, 06 Nov 2020 06:43:53 +0100 Martin Schiller wrote: > On 2020-11-05 16:06, Arnd Bergmann wrote: > > ... > > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing > > list to Cc. When I last looked at the wan drivers, I think I concluded > > that this should still be kept around

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-06 Thread Xie He
On Fri, Nov 6, 2020 at 1:03 AM David Laight wrote: > > Hmmm LAPB would expect to have an X.25 level 3 and maybe ISO > transport (class 0, 2 or 3) sat on top of it. I actually used AF_PACKET sockets to transport data directly over LAPB and it worked. LAPB doesn't need anything from layer 3. I

RE: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-06 Thread David Laight
From: Xie He > Sent: 05 November 2020 22:47 > > On Thu, Nov 5, 2020 at 12:40 PM Arnd Bergmann wrote: > > > > > I think this driver never worked. Looking at the original code in > > > Linux 2.1.31, it already has the problems I fixed in commit > > > 8fdcabeac398. > > > > > > I guess when people (o

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Martin Schiller
On 2020-11-05 16:06, Arnd Bergmann wrote: ... Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing list to Cc. When I last looked at the wan drivers, I think I concluded that this should still be kept around, but I do not remember why. OTOH if it was broken for a long time, that i

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Xie He
On Thu, Nov 5, 2020 at 12:40 PM Arnd Bergmann wrote: > > > I think this driver never worked. Looking at the original code in > > Linux 2.1.31, it already has the problems I fixed in commit > > 8fdcabeac398. > > > > I guess when people (or bots) say they "tested", they have not > > necessarily used

RE: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread David Laight
From: Xie He > Sent: 05 November 2020 19:35 > > On Thu, Nov 5, 2020 at 1:10 AM David Laight wrote: > > > > > This driver transports LAPB (X.25 link layer) frames over TTY links. > > > > I don't remember any requests to run LAPB over anything other > > than synchronous links when I was writing LAP

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Arnd Bergmann
On Thu, Nov 5, 2020 at 9:06 PM Xie He wrote: > > On Thu, Nov 5, 2020 at 7:07 AM Arnd Bergmann wrote: > > > > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing > > list to Cc. > > The linux-x25 mail list has stopped working for a long time. > > > When I last looked at the wan dr

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Xie He
On Thu, Nov 5, 2020 at 7:07 AM Arnd Bergmann wrote: > > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing > list to Cc. The linux-x25 mail list has stopped working for a long time. > When I last looked at the wan drivers, I think I concluded > that this should still be kept ar

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Xie He
On Thu, Nov 5, 2020 at 1:10 AM David Laight wrote: > > > This driver transports LAPB (X.25 link layer) frames over TTY links. > > I don't remember any requests to run LAPB over anything other > than synchronous links when I was writing LAPB implementation(s) > back in the mid 1980's. > > If you ne

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread Arnd Bergmann
On Thu, Nov 5, 2020 at 8:34 AM Xie He wrote: > > This driver transports LAPB (X.25 link layer) frames over TTY links. > > I can safely say that this driver has no actual user because it was > not working at all until: > commit 8fdcabeac398 ("drivers/net/wan/x25_asy: Fix to make it work") > > The c

RE: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-05 Thread David Laight
From: Xie He > Sent: 05 November 2020 07:35 > > This driver transports LAPB (X.25 link layer) frames over TTY links. I don't remember any requests to run LAPB over anything other than synchronous links when I was writing LAPB implementation(s) back in the mid 1980's. If you need to run 'comms ov

[PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-04 Thread Xie He
This driver transports LAPB (X.25 link layer) frames over TTY links. I can safely say that this driver has no actual user because it was not working at all until: commit 8fdcabeac398 ("drivers/net/wan/x25_asy: Fix to make it work") The code in its current state still has problems: 1. The uses of