Re: [PATCH net-next] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-24 Thread Florian Fainelli
On 9/24/2020 4:46 PM, Jakub Kicinski wrote: On Wed, 23 Sep 2020 21:16:27 -0700 Florian Fainelli wrote: While we should always make sure that we specify a valid VLAN protocol to vlan_proto_idx(), killing the machine when an invalid value is specified is too harsh and not helpful for debugging.

Re: [PATCH net-next] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 21:16:27 -0700 Florian Fainelli wrote: > While we should always make sure that we specify a valid VLAN protocol > to vlan_proto_idx(), killing the machine when an invalid value is > specified is too harsh and not helpful for debugging. All callers are > capable of dealing with a

[PATCH net-next] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-23 Thread Florian Fainelli
While we should always make sure that we specify a valid VLAN protocol to vlan_proto_idx(), killing the machine when an invalid value is specified is too harsh and not helpful for debugging. All callers are capable of dealing with an error returned by vlan_proto_idx() so check the index value and p