Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-02-20 Thread maowenan
On 2019/1/31 12:33, Tom Herbert wrote: > On Wed, Jan 30, 2019 at 6:59 PM maowenan wrote: >> >> >> >> On 2019/1/31 10:43, Tom Herbert wrote: >>> On Wed, Jan 30, 2019 at 5:58 PM maowenan wrote: On 2019/1/30 4:24, Tom Herbert wrote: > On Tue, Jan 29, 2019 at 12:08 AM maowe

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-30 Thread Tom Herbert
On Wed, Jan 30, 2019 at 6:59 PM maowenan wrote: > > > > On 2019/1/31 10:43, Tom Herbert wrote: > > On Wed, Jan 30, 2019 at 5:58 PM maowenan wrote: > >> > >> > >> > >> On 2019/1/30 4:24, Tom Herbert wrote: > >>> On Tue, Jan 29, 2019 at 12:08 AM maowenan wrote: > > > > On 2019/

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-30 Thread maowenan
On 2019/1/31 10:43, Tom Herbert wrote: > On Wed, Jan 30, 2019 at 5:58 PM maowenan wrote: >> >> >> >> On 2019/1/30 4:24, Tom Herbert wrote: >>> On Tue, Jan 29, 2019 at 12:08 AM maowenan wrote: On 2019/1/29 14:24, Tom Herbert wrote: > On Mon, Jan 28, 2019 at 10:04 PM maow

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-30 Thread Tom Herbert
On Wed, Jan 30, 2019 at 5:58 PM maowenan wrote: > > > > On 2019/1/30 4:24, Tom Herbert wrote: > > On Tue, Jan 29, 2019 at 12:08 AM maowenan wrote: > >> > >> > >> > >> On 2019/1/29 14:24, Tom Herbert wrote: > >>> On Mon, Jan 28, 2019 at 10:04 PM maowenan wrote: > > > > On 2019

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-30 Thread maowenan
On 2019/1/30 4:24, Tom Herbert wrote: > On Tue, Jan 29, 2019 at 12:08 AM maowenan wrote: >> >> >> >> On 2019/1/29 14:24, Tom Herbert wrote: >>> On Mon, Jan 28, 2019 at 10:04 PM maowenan wrote: On 2019/1/29 12:01, Tom Herbert wrote: > On Mon, Jan 28, 2019 at 7:00 PM maow

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-29 Thread Tom Herbert
On Tue, Jan 29, 2019 at 12:08 AM maowenan wrote: > > > > On 2019/1/29 14:24, Tom Herbert wrote: > > On Mon, Jan 28, 2019 at 10:04 PM maowenan wrote: > >> > >> > >> > >> On 2019/1/29 12:01, Tom Herbert wrote: > >>> On Mon, Jan 28, 2019 at 7:00 PM maowenan wrote: > > Hi all， > Do yo

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-29 Thread maowenan
On 2019/1/29 14:24, Tom Herbert wrote: > On Mon, Jan 28, 2019 at 10:04 PM maowenan wrote: >> >> >> >> On 2019/1/29 12:01, Tom Herbert wrote: >>> On Mon, Jan 28, 2019 at 7:00 PM maowenan wrote: Hi all， Do you have any comments about this change? On 2019/1/23 11:33,

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-28 Thread Tom Herbert
On Mon, Jan 28, 2019 at 10:04 PM maowenan wrote: > > > > On 2019/1/29 12:01, Tom Herbert wrote: > > On Mon, Jan 28, 2019 at 7:00 PM maowenan wrote: > >> > >> Hi all， > >> Do you have any comments about this change? > >> > >> > >> On 2019/1/23 11:33, Mao Wenan wrote: > >>> When udp4_gro_receive()

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-28 Thread maowenan
On 2019/1/29 12:01, Tom Herbert wrote: > On Mon, Jan 28, 2019 at 7:00 PM maowenan wrote: >> >> Hi all， >> Do you have any comments about this change? >> >> >> On 2019/1/23 11:33, Mao Wenan wrote: >>> When udp4_gro_receive() get one packet that uh->check=0, >>> skb_gro_checksum_validate_zero_che

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-28 Thread Tom Herbert
On Mon, Jan 28, 2019 at 7:00 PM maowenan wrote: > > Hi all， > Do you have any comments about this change? > > > On 2019/1/23 11:33, Mao Wenan wrote: > > When udp4_gro_receive() get one packet that uh->check=0, > > skb_gro_checksum_validate_zero_check() will set the > > skb->ip_summed = CHECKSUM_UN

Re: [PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-28 Thread maowenan
Hi all， Do you have any comments about this change? On 2019/1/23 11:33, Mao Wenan wrote: > When udp4_gro_receive() get one packet that uh->check=0, > skb_gro_checksum_validate_zero_check() will set the > skb->ip_summed = CHECKSUM_UNNECESSARY; > skb->csum_level = 0; > Then udp_gro_receive() will f

[PATCH net-next] net: udp Allow CHECKSUM_UNNECESSARY packets to do GRO.

2019-01-22 Thread Mao Wenan
When udp4_gro_receive() get one packet that uh->check=0, skb_gro_checksum_validate_zero_check() will set the skb->ip_summed = CHECKSUM_UNNECESSARY; skb->csum_level = 0; Then udp_gro_receive() will flush the packet which is not CHECKSUM_PARTIAL, It is not our expect, because check=0 in udp header i