Re: [PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

2015-06-11 Thread Daniel Borkmann
On 06/11/2015 07:11 AM, Eric Dumazet wrote: From: Eric Dumazet dctcp_alpha can be read by from dctcp_get_info() without synchro, so use WRITE_ONCE() to prevent compiler from using dctcp_alpha as a temporary variable. Also, playing with small dctcp_shift_g (like 1), can expose an overflow with

Re: [PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

2015-06-10 Thread David Miller
From: Eric Dumazet Date: Wed, 10 Jun 2015 22:11:17 -0700 > From: Eric Dumazet > > dctcp_alpha can be read by from dctcp_get_info() without > synchro, so use WRITE_ONCE() to prevent compiler from using > dctcp_alpha as a temporary variable. > > Also, playing with small dctcp_shift_g (like 1), c

[PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

2015-06-10 Thread Eric Dumazet
From: Eric Dumazet dctcp_alpha can be read by from dctcp_get_info() without synchro, so use WRITE_ONCE() to prevent compiler from using dctcp_alpha as a temporary variable. Also, playing with small dctcp_shift_g (like 1), can expose an overflow with 32bit values shifted 9 times before divide. U