Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-04 Thread kbuild test robot
Hi Jose, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Add-support-for-U32-TC-filter-using-Flexible-RX-Parser/20180504-164205 reproduce: # apt-get install sparse

Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-03 Thread Jakub Kicinski
On Thu, 3 May 2018 13:45:30 +0100, Jose Abreu wrote: > + case TC_SETUP_CLSU32: > + if (!(priv->dev->hw_features & NETIF_F_HW_TC)) > + ret = -EOPNOTSUPP; > + else > + ret = stmmac_tc_setup_cls_u32(priv, priv, type_data); > +

Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-03 Thread David Miller
From: Jose Abreu Date: Thu, 3 May 2018 13:45:30 +0100 > +static int dwmac5_rxp_update_single_entry(void __iomem *ioaddr, > + struct stmmac_tc_entry *entry, int pos) Please follow the Linux networking coding style for function arguments in function declarations and definitions. Each

[PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-03 Thread Jose Abreu
This adds support for U32 filter by using an HW only feature called Flexible RX Parser. This allow us to match any given packet field with a pattern and accept/reject or even route the packet to a specific DMA channel. Right now we only support acception or rejection of frame and we only support s