Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-03-04 Thread Vlad Buslov
On Sat 02 Mar 2019 at 01:17, Cong Wang wrote: > On Thu, Feb 28, 2019 at 7:49 AM Vlad Buslov wrote: >> >> However, if we revert NULL fixes dump will print general tp information >> for same tp twice (once correctly before dumping all filters on the tp, and >> second time when called for bogus NU

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-03-01 Thread Cong Wang
On Thu, Feb 28, 2019 at 7:49 AM Vlad Buslov wrote: > > However, if we revert NULL fixes dump will print general tp information > for same tp twice (once correctly before dumping all filters on the tp, and > second time when called for bogus NULL filter), like this: > > filter protocol ip pref 1 fl

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-28 Thread Vlad Buslov
On Wed 27 Feb 2019 at 23:09, Cong Wang wrote: > On Wed, Feb 27, 2019 at 6:28 AM Vlad Buslov wrote: >> >> >> On Tue 26 Feb 2019 at 22:38, Cong Wang wrote: >> > On Tue, Feb 26, 2019 at 7:08 AM Vlad Buslov wrote: >> >> >> >> >> >> On Mon 25 Feb 2019 at 22:52, Cong Wang wrote: >> >> > On Mon, Fe

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-27 Thread Cong Wang
On Wed, Feb 27, 2019 at 6:28 AM Vlad Buslov wrote: > > > On Tue 26 Feb 2019 at 22:38, Cong Wang wrote: > > On Tue, Feb 26, 2019 at 7:08 AM Vlad Buslov wrote: > >> > >> > >> On Mon 25 Feb 2019 at 22:52, Cong Wang wrote: > >> > On Mon, Feb 25, 2019 at 7:38 AM Vlad Buslov wrote: > >> >> > >> >> U

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-27 Thread Vlad Buslov
On Tue 26 Feb 2019 at 22:38, Cong Wang wrote: > On Tue, Feb 26, 2019 at 7:08 AM Vlad Buslov wrote: >> >> >> On Mon 25 Feb 2019 at 22:52, Cong Wang wrote: >> > On Mon, Feb 25, 2019 at 7:38 AM Vlad Buslov wrote: >> >> >> >> Using tcf_walker->stop flag to determine when tcf_walker->fn() was call

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-26 Thread Cong Wang
On Tue, Feb 26, 2019 at 7:08 AM Vlad Buslov wrote: > > > On Mon 25 Feb 2019 at 22:52, Cong Wang wrote: > > On Mon, Feb 25, 2019 at 7:38 AM Vlad Buslov wrote: > >> > >> Using tcf_walker->stop flag to determine when tcf_walker->fn() was called > >> at least once is unreliable. Some classifiers set

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-26 Thread Vlad Buslov
On Mon 25 Feb 2019 at 22:52, Cong Wang wrote: > On Mon, Feb 25, 2019 at 7:38 AM Vlad Buslov wrote: >> >> Using tcf_walker->stop flag to determine when tcf_walker->fn() was called >> at least once is unreliable. Some classifiers set 'stop' flag on error >> before calling walker callback, other c

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-25 Thread Cong Wang
On Mon, Feb 25, 2019 at 7:38 AM Vlad Buslov wrote: > > Using tcf_walker->stop flag to determine when tcf_walker->fn() was called > at least once is unreliable. Some classifiers set 'stop' flag on error > before calling walker callback, other classifiers used to call it with NULL > filter pointer w

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-25 Thread David Miller
From: Vlad Buslov Date: Mon, 25 Feb 2019 17:38:31 +0200 > Using tcf_walker->stop flag to determine when tcf_walker->fn() was called > at least once is unreliable. Some classifiers set 'stop' flag on error > before calling walker callback, other classifiers used to call it with NULL > filter point

[PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-02-25 Thread Vlad Buslov
Using tcf_walker->stop flag to determine when tcf_walker->fn() was called at least once is unreliable. Some classifiers set 'stop' flag on error before calling walker callback, other classifiers used to call it with NULL filter pointer when empty. In order to prevent further regressions, extend tcf