Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-12-02 Thread Vlad Buslov
On Tue 01 Dec 2020 at 21:24, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 20:39:16 +0200 Vlad Buslov wrote: >> On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote: >> > On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote: >> >> On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: >> >> > On Fri,

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 20:39:16 +0200 Vlad Buslov wrote: > On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote: > > On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote: > >> On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: > >> > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: > >> >> @

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-12-01 Thread Vlad Buslov
On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote: >> On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: >> > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: >> >> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb,

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-12-01 Thread Jakub Kicinski
On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote: > On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: > > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: > >> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, > >> struct nlmsghdr *n, > >> > >>if (prio == 0) {

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-11-30 Thread Vlad Buslov
On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: >> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct >> nlmsghdr *n, >> >> if (prio == 0) { >> tfilter_notify_chain(net, skb, block, q, parent,

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-11-30 Thread Jakub Kicinski
On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote: > @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct > nlmsghdr *n, > > if (prio == 0) { > tfilter_notify_chain(net, skb, block, q, parent, n, > - chain, RTM_DELTFI

[PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-11-27 Thread Vlad Buslov
Functions tfilter_notify_chain() and tcf_get_next_proto() are always called with rtnl lock held in current implementation. Moreover, attempting to call them without rtnl lock would cause a warning down the call chain in function __tcf_get_next_proto() that requires the lock to be held by callers. R