Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-11 Thread David Miller
From: Vlad Buslov Date: Mon, 9 Jul 2018 20:26:47 +0300 > Fix action attribute size calculation function to take rcu read lock and > access act_cookie pointer with rcu dereference. > > Fixes: eec94fdb0480 ("net: sched: use rcu for action cookie update") > Reported-by: Marcelo Ricardo Leitner >

Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-11 Thread Marcelo Ricardo Leitner
On Mon, Jul 09, 2018 at 11:44:38PM +0300, Vlad Buslov wrote: > > On Mon 09 Jul 2018 at 20:34, Marcelo Ricardo Leitner > wrote: > > On Mon, Jul 09, 2018 at 08:26:47PM +0300, Vlad Buslov wrote: > >> Fix action attribute size calculation function to take rcu read lock and > >> access act_cookie poi

Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-09 Thread Eric Dumazet
On 07/09/2018 01:34 PM, Marcelo Ricardo Leitner wrote: > I am not sure if this is enough to fix the entire issue. Now it will > fetch the length correctly but, what guarantees that when it tries to > actually copy the key (tcf_action_dump_1), the same act_cookie pointer > will be used? As in, c

Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-09 Thread Vlad Buslov
On Mon 09 Jul 2018 at 20:34, Marcelo Ricardo Leitner wrote: > On Mon, Jul 09, 2018 at 08:26:47PM +0300, Vlad Buslov wrote: >> Fix action attribute size calculation function to take rcu read lock and >> access act_cookie pointer with rcu dereference. >> >> Fixes: eec94fdb0480 ("net: sched: use

Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-09 Thread Marcelo Ricardo Leitner
On Mon, Jul 09, 2018 at 08:26:47PM +0300, Vlad Buslov wrote: > Fix action attribute size calculation function to take rcu read lock and > access act_cookie pointer with rcu dereference. > > Fixes: eec94fdb0480 ("net: sched: use rcu for action cookie update") > Reported-by: Marcelo Ricardo Leitner

[PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-09 Thread Vlad Buslov
Fix action attribute size calculation function to take rcu read lock and access act_cookie pointer with rcu dereference. Fixes: eec94fdb0480 ("net: sched: use rcu for action cookie update") Reported-by: Marcelo Ricardo Leitner Signed-off-by: Vlad Buslov --- net/sched/act_api.c | 9 +++-- 1