Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-03-04 Thread Vlad Buslov
On Sat 02 Mar 2019 at 00:08, Cong Wang wrote: > On Thu, Feb 28, 2019 at 6:53 AM Vlad Buslov wrote: >> >> >> On Wed 27 Feb 2019 at 23:03, Cong Wang wrote: >> > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: >> >> >> >> >> >> On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: >> >> > On Mon, Fe

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-03-01 Thread Cong Wang
On Thu, Feb 28, 2019 at 6:53 AM Vlad Buslov wrote: > > > On Wed 27 Feb 2019 at 23:03, Cong Wang wrote: > > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: > >> > >> > >> On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: > >> > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: > >> >> > >> >> F

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-28 Thread Vlad Buslov
On Wed 27 Feb 2019 at 23:03, Cong Wang wrote: > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: >> >> >> On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: >> > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: >> >> >> >> Function tc_dump_chain() obtains and releases block->lock on each >> >

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-27 Thread Cong Wang
On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: > > > On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: > > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: > >> > >> Function tc_dump_chain() obtains and releases block->lock on each iteration > >> of its inner loop that dumps all chains on bloc

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-26 Thread Vlad Buslov
On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: >> >> Function tc_dump_chain() obtains and releases block->lock on each iteration >> of its inner loop that dumps all chains on block. Outputting chain template >> info is fast operation so lockin

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-25 Thread Cong Wang
On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: > > Function tc_dump_chain() obtains and releases block->lock on each iteration > of its inner loop that dumps all chains on block. Outputting chain template > info is fast operation so locking/unlocking mutex multiple times is an > overhead when

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-25 Thread David Miller
From: Vlad Buslov Date: Mon, 25 Feb 2019 17:45:44 +0200 > Function tc_dump_chain() obtains and releases block->lock on each iteration > of its inner loop that dumps all chains on block. Outputting chain template > info is fast operation so locking/unlocking mutex multiple times is an > overhead w

[PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-02-25 Thread Vlad Buslov
Function tc_dump_chain() obtains and releases block->lock on each iteration of its inner loop that dumps all chains on block. Outputting chain template info is fast operation so locking/unlocking mutex multiple times is an overhead when lock is highly contested. Modify tc_dump_chain() to only obtai