Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-31 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Fri, 27 Oct 2017 14:30:08 -0600 > For deaggregation, the real device receives a large linear skb and > passes it on to rmnet. rmnet creates new skbs from this large frame. > > If the real device supports recycling, it does not need to allocate > the lar

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-27 Thread Alexander Duyck
On Fri, Oct 27, 2017 at 3:22 PM, Subash Abhinov Kasiviswanathan wrote: >> This doesn't make sense to me, maybe I am missing something. What >> "real device" is setting the skb->destructor() and doing it to somehow >> handle recycling? The only driver I can find that is setting >> skb->desctructor(

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-27 Thread Subash Abhinov Kasiviswanathan
This doesn't make sense to me, maybe I am missing something. What "real device" is setting the skb->destructor() and doing it to somehow handle recycling? The only driver I can find that is setting skb->desctructor() is the Chelsio drivers, and they appear to be using it to just clean-up DMA mappi

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-27 Thread Alexander Duyck
On Fri, Oct 27, 2017 at 1:30 PM, Subash Abhinov Kasiviswanathan wrote: > For deaggregation, the real device receives a large linear skb and > passes it on to rmnet. rmnet creates new skbs from this large frame. > > If the real device supports recycling, it does not need to allocate > the large skb

[PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-27 Thread Subash Abhinov Kasiviswanathan
For deaggregation, the real device receives a large linear skb and passes it on to rmnet. rmnet creates new skbs from this large frame. If the real device supports recycling, it does not need to allocate the large skbs during packet reception and can instead reuse them. Signed-off-by: Subash Abhi