>> Just cosmetic thing.
>> How about aligning with other members in structure like
>
>Yes, i can do that. v2 tomorrow sometime.
Thanks.
>
>Can you confirm the LAN911x Internal PHY don't have this. The register
>is not listed in the switch datasheet.
>
This register is NOT in LAN911x internal phy.
Hi Woojung
> Just cosmetic thing.
> How about aligning with other members in structure like
Yes, i can do that. v2 tomorrow sometime.
> > + .get_sset_count = smsc_get_sset_count,
> > + .get_strings = smsc_get_strings,
> > + .get_stats= smsc_get_stats,
>
> Reviewed-By: Woojung
On 06/02/2017 02:24 PM, Andrew Lunn wrote:
> Most of the PHYs supported by the SMSC driver have a counter of symbol
> errors. This is 16 bit wide and wraps around when it reaches its
> maximum value.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
Andrew,
> static int smsc_phy_probe(struct phy_device *phydev)
> {
> struct device *dev = &phydev->mdio.dev;
> @@ -206,6 +258,11 @@ static struct phy_driver smsc_phy_driver[] = {
> .ack_interrupt = smsc_phy_ack_interrupt,
> .config_intr= smsc_phy_config_intr,
>
> + /*
Most of the PHYs supported by the SMSC driver have a counter of symbol
errors. This is 16 bit wide and wraps around when it reaches its
maximum value.
Signed-off-by: Andrew Lunn
---
drivers/net/phy/smsc.c | 72 ++
1 file changed, 72 insertions(+)
