Re: [PATCH net-next] net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT

2021-02-14 Thread Russell King - ARM Linux admin
On Sun, Feb 14, 2021 at 03:16:23PM +0100, Heiner Kallweit wrote: > Some internal PHY's have their events like link change reported by the > MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario. > I'm not too happy with this name. We don't ignore interrupts, typically > there is no

Re: [PATCH net-next] net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT

2021-02-14 Thread Florian Fainelli
On 2/14/2021 6:16 AM, Heiner Kallweit wrote: > Some internal PHY's have their events like link change reported by the > MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario. > I'm not too happy with this name. We don't ignore interrupts, typically > there is no interrupt expose

Re: [PATCH net-next] net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT

2021-02-14 Thread Andrew Lunn
On Sun, Feb 14, 2021 at 03:16:23PM +0100, Heiner Kallweit wrote: > Some internal PHY's have their events like link change reported by the > MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario. > I'm not too happy with this name. We don't ignore interrupts, typically > there is no

[PATCH net-next] net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT

2021-02-14 Thread Heiner Kallweit
Some internal PHY's have their events like link change reported by the MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario. I'm not too happy with this name. We don't ignore interrupts, typically there is no interrupt exposed at a PHY level. So let's rename it to PHY_MAC_INTERRUP