Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Jerome Brunet
On Tue, 2017-12-05 at 19:01 +0100, Andrew Lunn wrote: > On Tue, Dec 05, 2017 at 10:33:34AM +0100, Jerome Brunet wrote: > > From: Neil Armstrong > > > > Define registers and bits in meson-gxl PHY driver to make a bit > > more human friendly. No functional change > > > > static int meson_gxl_con

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Andrew Lunn
On Tue, Dec 05, 2017 at 10:33:34AM +0100, Jerome Brunet wrote: > From: Neil Armstrong > > Define registers and bits in meson-gxl PHY driver to make a bit > more human friendly. No functional change > static int meson_gxl_config_init(struct phy_device *phydev) > { > - /* Enable Analog and

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Jerome Brunet
On Tue, 2017-12-05 at 23:23 +0800, Yixun Lan wrote: > > +static inline int meson_gxl_write_reg(struct phy_device *phydev, > > + unsigned int bank, unsigned int reg, > > + uint16_t value) > > +{ > > + int ret; > > + > > + /*

Re: [PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Yixun Lan
HI Jerome: On 12/05/17 17:33, Jerome Brunet wrote: > From: Neil Armstrong > > Define registers and bits in meson-gxl PHY driver to make a bit > more human friendly. No functional change > > Signed-off-by: Neil Armstrong > Signed-off-by: Jerome Brunet > --- > drivers/net/phy/meson-gxl.c | 11

[PATCH net-next] net: phy: meson-gxl: cleanup by defining the control registers

2017-12-05 Thread Jerome Brunet
From: Neil Armstrong Define registers and bits in meson-gxl PHY driver to make a bit more human friendly. No functional change Signed-off-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 111 +--- 1 file changed, 93 inse