Re: [PATCH net-next] net: phy: improve setting advertised modes in phy_probe

On Sun, Apr 28, 2019 at 08:10:43PM +0200, Heiner Kallweit wrote: > On 28.04.2019 19:04, Andrew Lunn wrote: > > On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote: > >> So far we set the advertising bitmap before setting the pause flags > >> in the supported bitmap. This may cause pause

Re: [PATCH net-next] net: phy: improve setting advertised modes in phy_probe

On 28.04.2019 19:04, Andrew Lunn wrote: > On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote: >> So far we set the advertising bitmap before setting the pause flags >> in the supported bitmap. This may cause pause not being advertised. > > Hi Heiner > > Pause requires that the PHY ca

Re: [PATCH net-next] net: phy: improve setting advertised modes in phy_probe

On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote: > So far we set the advertising bitmap before setting the pause flags > in the supported bitmap. This may cause pause not being advertised. Hi Heiner Pause requires that the PHY can advertise the pause bits, and that the MAC support

[PATCH net-next] net: phy: improve setting advertised modes in phy_probe

So far we set the advertising bitmap before setting the pause flags in the supported bitmap. This may cause pause not being advertised. At least r8169 driver works around this by copying supported -> advertising on its own. The linkmode bitmaps have been introduced only recently, therefore the patc